modify the contributing guide a tad bit to use uv run python -m reflex.utils.pyi_generator#5576
Merged
adhami3310 merged 1 commit intoJul 16, 2025
Conversation
…x.utils.pyi_generator
Contributor
There was a problem hiding this comment.
Greptile Summary
This PR makes a targeted change to the CONTRIBUTING.md guide, modifying the command used to generate .pyi files from uv run python scripts/make_pyi.py to uv run python -m reflex.utils.pyi_generator. This change reflects an architectural improvement where the pyi generator has been properly modularized within the reflex.utils package.
The new approach using Python's module system (-m flag) is more robust as it:
- Ensures proper module resolution through Python's import system
- Is more resilient to different installation setups and environments
- Follows better Python packaging practices by treating the generator as a proper module
Confidence score: 5/5
- This is a safe documentation update that reflects an existing architectural improvement
- The change is straightforward, correct, and follows Python best practices for module organization
- No files need special attention as this is a simple documentation update reflecting an existing change
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
CodSpeed Performance ReportMerging #5576 will not alter performanceComparing Summary
|
Lendemor
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.