clean up app._compile#5599
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Greptile Summary
This PR performs a significant architectural cleanup by removing FastAPI dependency in favor of using Starlette directly. The key changes include:
- Simplifying the
__call__method inapp.pyby removing ThreadPoolExecutor and FastAPI-specific code - Adding GLOBAL_CACHE clearing after compilation to improve memory efficiency
- Updating dependency requirements in pyproject.toml to use Starlette >=0.47.0 instead of FastAPI
The changes are part of a larger effort to streamline the framework by removing unnecessary layers and improving memory efficiency. The removal of FastAPI indicates that the project only needs Starlette's core ASGI functionality, making the codebase leaner and more focused.
Confidence score: 4/5
- This PR is generally safe to merge as it simplifies rather than adds complexity
- High score given because the changes are well-focused on removing unnecessary code and dependencies
- Files needing attention:
- app.py: Verify that all FastAPI functionality has been properly replaced
- Integration tests: Ensure ASGI functionality remains intact
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
CodSpeed Performance ReportMerging #5599 will not alter performanceComparing Summary
|
masenf
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.