install only the shell for app harness#5653
Conversation
There was a problem hiding this comment.
Greptile Summary
This PR modifies the GitHub Actions workflow for integration app harness testing by changing how Playwright and Chromium are installed. The key change is switching from the default Playwright installation to using the --only-shell flag when installing Chromium.
Specifically, the workflow now:
- Separates Playwright installation into its own dedicated step
- Uses
uv run playwright install chromium --only-shellinstead of the standard installation - Maintains the same test execution step that runs pytest with retries and parallel execution
The --only-shell flag installs a minimal version of Chromium without the full browser binaries, which can significantly reduce installation time and disk space usage in CI environments. This change fits into the broader CI/CD infrastructure where multiple integration test workflows exist (as seen in integration_tests.yml and reflex_init_in_docker_test.yml), and optimizing build times across these workflows can improve overall developer productivity.
The change appears to be experimental, as the developer wants to verify through CI whether the shell-only installation provides sufficient browser capabilities for the app harness integration tests.
Confidence score: 3/5
- This change is moderately safe but carries some risk of test functionality degradation
- The
--only-shellflag may not provide all browser features needed for comprehensive integration testing, potentially causing test failures or reduced test coverage - The
.github/workflows/integration_app_harness.ymlfile needs careful monitoring to ensure the minimal Chromium installation supports all required test scenarios
1 file reviewed, no comments
CodSpeed Performance ReportMerging #5653 will not alter performanceComparing Summary
|
not sure if it has the same exact feature, but i guess we will check the CI