Skip to content

install only the shell for app harness#5653

Merged
adhami3310 merged 1 commit into
mainfrom
install-only-the-shell-for-app-harness
Aug 6, 2025
Merged

install only the shell for app harness#5653
adhami3310 merged 1 commit into
mainfrom
install-only-the-shell-for-app-harness

Conversation

@adhami3310
Copy link
Copy Markdown
Member

not sure if it has the same exact feature, but i guess we will check the CI

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR modifies the GitHub Actions workflow for integration app harness testing by changing how Playwright and Chromium are installed. The key change is switching from the default Playwright installation to using the --only-shell flag when installing Chromium.

Specifically, the workflow now:

  1. Separates Playwright installation into its own dedicated step
  2. Uses uv run playwright install chromium --only-shell instead of the standard installation
  3. Maintains the same test execution step that runs pytest with retries and parallel execution

The --only-shell flag installs a minimal version of Chromium without the full browser binaries, which can significantly reduce installation time and disk space usage in CI environments. This change fits into the broader CI/CD infrastructure where multiple integration test workflows exist (as seen in integration_tests.yml and reflex_init_in_docker_test.yml), and optimizing build times across these workflows can improve overall developer productivity.

The change appears to be experimental, as the developer wants to verify through CI whether the shell-only installation provides sufficient browser capabilities for the app harness integration tests.

Confidence score: 3/5

  • This change is moderately safe but carries some risk of test functionality degradation
  • The --only-shell flag may not provide all browser features needed for comprehensive integration testing, potentially causing test failures or reduced test coverage
  • The .github/workflows/integration_app_harness.yml file needs careful monitoring to ensure the minimal Chromium installation supports all required test scenarios

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jul 31, 2025

CodSpeed Performance Report

Merging #5653 will not alter performance

Comparing install-only-the-shell-for-app-harness (fda7de5) with main (687d20f)

Summary

✅ 8 untouched benchmarks

@adhami3310 adhami3310 merged commit 81b1b56 into main Aug 6, 2025
52 of 53 checks passed
@adhami3310 adhami3310 deleted the install-only-the-shell-for-app-harness branch August 6, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants