Skip to content

get the running loop to compile async state #5657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adhami3310 merged 3 commits into from
Aug 1, 2025
Merged

get the running loop to compile async state #5657

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5457874
get the running loop to compile async state
adhami3310 Aug 1, 2025
22ad425
let's try
adhami3310 Aug 1, 2025
413d72d
ok i hate this
adhami3310 Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions reflex/compiler/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
from reflex.istate.storage import Cookie, LocalStorage, SessionStorage
from reflex.state import BaseState, _resolve_delta
from reflex.style import Style
from reflex.utils import console, format, imports, path_ops
from reflex.utils.exec import is_in_app_harness
from reflex.utils import format, imports, path_ops
from reflex.utils.imports import ImportVar, ParsedImportDict
from reflex.utils.prerequisites import get_web_dir
from reflex.vars.base import Field, Var
Expand Down Expand Up @@ -201,16 +200,11 @@ def compile_state(state: type[BaseState]) -> dict:
except RuntimeError:
pass
else:
if is_in_app_harness():
# Playwright tests already have an event loop running, so we can't use asyncio.run.
with concurrent.futures.ThreadPoolExecutor() as pool:
resolved_initial_state = pool.submit(
asyncio.run, _resolve_delta(initial_state)
).result()
console.warn(
f"Had to get initial state in a thread 🤮 {resolved_initial_state}",
)
return _sorted_keys(resolved_initial_state)
with concurrent.futures.ThreadPoolExecutor() as pool:
resolved_initial_state = pool.submit(
asyncio.run, _resolve_delta(initial_state)
).result()
return _sorted_keys(resolved_initial_state)

# Normally the compile runs before any event loop starts, we asyncio.run is available for calling.
return _sorted_keys(asyncio.run(_resolve_delta(initial_state)))
Expand Down
Loading