Skip to content

update slider event spec #5828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adhami3310 merged 2 commits into from
Oct 2, 2025
Merged

update slider event spec #5828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cb9ffd
update slider event spec
adhami3310 Sep 27, 2025
5a5cf00
precommit
adhami3310 Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyi_hashes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"reflex/components/radix/primitives/drawer.pyi": "c6ad2f60217fe25952f3a1ba88fbd72a",
"reflex/components/radix/primitives/form.pyi": "8a5ec180a50acdc35dfe53e4e65c20e0",
"reflex/components/radix/primitives/progress.pyi": "b26c99c1d827c0f599fff344746aeec3",
"reflex/components/radix/primitives/slider.pyi": "c03b716ffbbc3e1a0c766951de04e83b",
"reflex/components/radix/primitives/slider.pyi": "be343dcd0558917b054683c99d539a43",
"reflex/components/radix/themes/__init__.pyi": "582b4a7ead62b2ae8605e17fa084c063",
"reflex/components/radix/themes/base.pyi": "3e1ccd5ce5fef0b2898025193ee3d069",
"reflex/components/radix/themes/color_mode.pyi": "744548322db3ce069c4b56341f274671",
Expand Down Expand Up @@ -82,7 +82,7 @@
"reflex/components/radix/themes/components/select.pyi": "f7196bf70b506b21ccce95301679b8b5",
"reflex/components/radix/themes/components/separator.pyi": "4db0b99e3ffc63c59a8d6d973c25495a",
"reflex/components/radix/themes/components/skeleton.pyi": "4bae01522e3f4efe5d04262c53f23571",
"reflex/components/radix/themes/components/slider.pyi": "3a5a53e655a74baf2110e46b526b6fb1",
"reflex/components/radix/themes/components/slider.pyi": "305a34c14ca8656ca9267e4c31aaa388",
"reflex/components/radix/themes/components/spinner.pyi": "476098d606a9271ff49d7bbbae285acd",
"reflex/components/radix/themes/components/switch.pyi": "1edf811e25894d44e7ec5a8f031ff86a",
"reflex/components/radix/themes/components/table.pyi": "6e49e5bf41fa9314a27887ce13f52955",
Expand Down
20 changes: 3 additions & 17 deletions reflex/components/radix/primitives/slider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

from reflex.components.component import Component, ComponentNamespace
from reflex.components.radix.primitives.base import RadixPrimitiveComponentWithClassName
from reflex.event import EventHandler
from reflex.event import EventHandler, passthrough_event_spec
from reflex.vars.base import Var

LiteralSliderOrientation = Literal["horizontal", "vertical"]
Expand All @@ -20,20 +20,6 @@ class SliderComponent(RadixPrimitiveComponentWithClassName):
library = "@radix-ui/react-slider@1.3.6"


def on_value_event_spec(
value: Var[list[int]],
) -> tuple[Var[list[int]]]:
"""Event handler spec for the value event.

Args:
value: The value of the event.

Returns:
The event handler spec.
"""
return (value,)


class SliderRoot(SliderComponent):
"""The Slider component containing all slider parts."""

Expand Down Expand Up @@ -63,10 +49,10 @@ class SliderRoot(SliderComponent):
min_steps_between_thumbs: Var[int]

# Fired when the value of a thumb changes.
on_value_change: EventHandler[on_value_event_spec]
on_value_change: EventHandler[passthrough_event_spec(list[float])]

# Fired when a thumb is released.
on_value_commit: EventHandler[on_value_event_spec]
on_value_commit: EventHandler[passthrough_event_spec(list[float])]

def add_style(self) -> dict[str, Any] | None:
"""Add style to the component.
Expand Down
3 changes: 1 addition & 2 deletions reflex/components/radix/themes/components/slider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,8 @@
from reflex.vars.base import Var

on_value_event_spec = (
passthrough_event_spec(list[int | float]),
passthrough_event_spec(list[int]),
passthrough_event_spec(list[float]),
passthrough_event_spec(list[int]),
)


Expand Down
Loading