dialog trigger must have dialog root as its parent

[adhami3310]

No description provided.

[codspeed-hq]

CodSpeed Performance Report

Merging #5896 will create unknown performance changes

_{Comparing trigger-must-be-inside-of-root (fe28e28) with main (fc0a6ca)}

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.
Please ensure that your benchmarks are correctly instrumented with CodSpeed.

Check out the benchmarks creation guide

⏩ 8 skipped¹

Footnotes

1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[greptile-apps]

Greptile Overview

Summary

Added _valid_parents constraint to DialogTrigger to enforce that it must be a direct child of DialogRoot, following the Radix UI Dialog component structure.

• Prevents runtime errors by validating component hierarchy at build time
• Missing ClassVar type annotation (should be added for consistency with other components)

Confidence Score: 4/5

• Safe to merge after fixing the type annotation
• The change correctly enforces parent-child relationships for Dialog components, but is missing the ClassVar type annotation that's used consistently across the codebase
• reflex/components/radix/primitives/dialog.py - needs ClassVar type annotation added

Important Files Changed

File Analysis

Filename	Score	Overview
reflex/components/radix/primitives/dialog.py	4/5	Added parent validation for DialogTrigger - missing ClassVar type annotation

Sequence Diagram

sequenceDiagram
    participant User
    participant DialogRoot
    participant DialogTrigger
    participant Component
    
    User->>DialogRoot: Create dialog.root()
    User->>DialogTrigger: Add dialog.trigger() as child
    DialogTrigger->>Component: Validate parent relationship
    Component->>Component: Check _valid_parents = ["DialogRoot"]
    alt Parent is DialogRoot
        Component-->>DialogTrigger: Validation passes
        DialogTrigger-->>User: Component renders correctly
    else Parent is not DialogRoot
        Component-->>User: Raise ValueError with message
    end

Loading

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

syntax: missing ClassVar type annotation - should match the pattern used in other components like AccordionItem, SelectTrigger, etc.

Suggested change

	_valid_parents = ["DialogRoot"]
	_valid_parents: ClassVar[list[str]] = ["DialogRoot"]

Prompt To Fix With AI

This is a comment left during a code review.
Path: reflex/components/radix/primitives/dialog.py
Line: 76:76

Comment:
**syntax:** missing `ClassVar` type annotation - should match the pattern used in other components like `AccordionItem`, `SelectTrigger`, etc.

```suggestion
    _valid_parents: ClassVar[list[str]] = ["DialogRoot"]
```

How can I resolve this? If you propose a fix, please make it concise.