Skip to content

dialog trigger must have dialog root as its parent #5896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adhami3310 merged 1 commit into from
Oct 16, 2025
+2 −0
Merged

dialog trigger must have dialog root as its parent #5896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions reflex/components/radix/primitives/dialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ class DialogTrigger(DialogElement, RadixPrimitiveTriggerComponent):

_memoization_mode = MemoizationMode(recursive=False)

_valid_parents = ["DialogRoot"]
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: missing ClassVar type annotation - should match the pattern used in other components like AccordionItem, SelectTrigger, etc.

Suggested change
_valid_parents = ["DialogRoot"]
_valid_parents: ClassVar[list[str]] = ["DialogRoot"]
Prompt To Fix With AI 
This is a comment left during a code review.
Path: reflex/components/radix/primitives/dialog.py
Line: 76:76

Comment:
**syntax:** missing `ClassVar` type annotation - should match the pattern used in other components like `AccordionItem`, `SelectTrigger`, etc.

```suggestion
    _valid_parents: ClassVar[list[str]] = ["DialogRoot"]
```

How can I resolve this? If you propose a fix, please make it concise.



class DialogContent(elements.Div, DialogElement):
"""Content component to display inside a Dialog modal."""
Expand Down
Loading