Skip to content

ENG-8049: pass correct parameters to queueEvents #5962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
masenf merged 1 commit into from
Nov 10, 2025
Merged

ENG-8049: pass correct parameters to queueEvents #5962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions reflex/.templates/web/utils/state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export const queueEventIfSocketExists = async (
if (!socket) {
return;
}
await queueEvents(events, socket, navigate, params);
await queueEvents(events, socket, false, navigate, params);
};

/**
Expand Down Expand Up @@ -256,13 +256,13 @@ export const applyEvent = async (event, socket, navigate, params) => {

if (event.name == "_clear_session_storage") {
sessionStorage.clear();
queueEvents(initialEvents(), socket, navigate, params);
queueEventIfSocketExists(initialEvents(), socket, navigate, params);
return false;
}

if (event.name == "_remove_session_storage") {
sessionStorage.removeItem(event.payload.key);
queueEvents(initialEvents(), socket, navigate, params);
queueEventIfSocketExists(initialEvents(), socket, navigate, params);
return false;
}

Expand Down
4 changes: 2 additions & 2 deletions reflex/utils/format.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,8 +586,8 @@ def _default_args_spec():
# Return the final code snippet, expecting queueEvents, processEvent, and socket to be in scope.
# Typically this snippet will _only_ run from within an rx.call_script eval context.
return Var(
f"{arg_def} => {{queueEvents([{','.join(payloads)}], {constants.CompileVars.SOCKET}); "
f"processEvent({constants.CompileVars.SOCKET})}}",
f"{arg_def} => {{queueEvents([{','.join(payloads)}], {constants.CompileVars.SOCKET}, false, navigate, params);"
f"processEvent({constants.CompileVars.SOCKET}, navigate, params);}}",
).to(FunctionVar, EventChain)


Expand Down
Loading