Fix computed var dep tracking error message#6039
Merged
adhami3310 merged 2 commits intomainfrom Dec 15, 2025
Merged
Conversation
The prop for static deps is actually `deps` not `static_deps`.
CodSpeed Performance ReportMerging #6039 will improve performances by 4.22%Comparing Summary
Benchmarks breakdown
|
Contributor
Greptile OverviewGreptile SummaryCorrected the error message in
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant CV as ComputedVar
participant DT as DependencyTracker
participant Console as Console
Dev->>CV: Define computed var with auto_deps=True
CV->>CV: _get_dependencies(obj, objclass)
alt Auto-dependency tracking enabled
CV->>DT: Track dependencies automatically
alt Tracking succeeds
DT-->>CV: Return dependencies
else Tracking fails
DT-->>CV: Raise exception
CV->>Console: Warn with corrected error message
Note over Console: "Set auto_deps=False and provide<br/>accurate deps=['var1', 'var2']"
CV-->>Dev: Return empty dependencies
end
else Auto-dependency disabled
CV-->>Dev: Use manually specified deps
end
|
adhami3310
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prop for static deps is actually
depsnotstatic_deps.