Skip to content

090dev#6182

Merged
adhami3310 merged 4 commits intomainfrom
0829dev
Mar 19, 2026
Merged

090dev#6182
adhami3310 merged 4 commits intomainfrom
0829dev

Conversation

@adhami3310
Copy link
Copy Markdown
Member

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 17, 2026

Merging this PR will not alter performance

✅ 8 untouched benchmarks


Comparing 0829dev (986cc74) with main (0a5e76e)

Open in CodSpeed

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 17, 2026

Greptile Summary

This PR bumps the Reflex version from 0.8.28dev1 to 0.8.29dev1 and rolls up a batch of frontend dependency upgrades, new Lucide icons, a ruff toolchain upgrade, and minor code/docstring cleanups.

Key changes:

  • Vite switch: Replaces the experimental npm:rolldown-vite@7.3.1 alias with official vite@8.0.0 in DEV_DEPENDENCIES and removes the corresponding OVERRIDES entry.
  • Dependency bumps: React 19.2.4, React Router 7.13.1, Bun 1.3.10, lucide-react 0.577.0, recharts 3.8.0, plotly.js 3.4.0, tailwindcss/postcss 4.2.1, react-syntax-highlighter 16.1.1, isbot, autoprefixer, postcss.
  • New icons: ellipse, fishing_rod, message_square_check, metronome, mouse_right, square_arrow_right_enter, square_arrow_right_exit, square_centerline_dashed_horizontal, square_centerline_dashed_vertical added to LUCIDE_ICON_LIST; the previously commented-out # "mouse_right" entry is removed.
  • Docstring ordering: Returns section moved before Raises across ~20 files for consistency.
  • Memory manager simplification: Intermediate state variable in StateManagerMemory.modify_state eliminated by yielding directly.
  • Test cleanup: Four # noqa: RUF036 suppression comments removed after ruff upgrade to v0.15.6.

Confidence Score: 4/5

  • This PR is safe to merge; it consists primarily of version bumps and non-functional docstring/style changes with one minor docstring artifact.
  • The changes are largely routine: frontend library upgrades, new icon entries, docstring reordering, and a trivial code simplification. The most impactful change—switching from npm:rolldown-vite@7.3.1 to vite@8.0.0—is a straightforward upgrade from the experimental rolldown distribution to the official Vite 8 release. The only identified issue is a cosmetic double blank line left in the on_event docstring after the reordering pass.
  • reflex/constants/installer.py (vite switch and multiple package bumps), reflex/app.py (double blank line in on_event docstring)

Important Files Changed

Filename Overview
reflex/constants/installer.py Significant dependency upgrades: React 19.2.4, React Router 7.13.1, Bun 1.3.10, isbot 5.1.36, autoprefixer 10.4.27, postcss 8.5.8; notably switches from experimental npm:rolldown-vite@7.3.1 to official vite@8.0.0 and removes the corresponding vite override entry.
reflex/app.py Docstring reordering (Returns before Raises) throughout; the on_event method ends up with a double blank line in its docstring due to the removal of a Raises block that preceded Args.
reflex/istate/manager/memory.py Minor code simplification: the intermediate state variable inside modify_state is removed and the awaited result is yielded directly — functionally equivalent.
reflex/components/lucide/icon.py Upgraded lucide-react from 0.574.0 to 0.577.0; added new icons (ellipse, fishing_rod, message_square_check, metronome, mouse_right, square_arrow_right_enter/exit, square_centerline_dashed_horizontal/vertical); removed the commented-out # "mouse_right" entry (now properly included).
reflex/components/plotly/plotly.py Bumped all plotly.js dist variants from 3.3.1 to 3.4.0 consistently across all PlotlyBasic, PlotlyCartesian, PlotlyGeo, PlotlyGl3d, PlotlyGl2d, PlotlyMapbox, PlotlyFinance, and PlotlyStrict classes.
reflex/plugins/tailwind_v4.py Upgraded both tailwindcss and @tailwindcss/postcss from 4.1.18 to 4.2.1.
tests/units/components/test_component.py Removed four # noqa: RUF036 suppression comments that are no longer needed with ruff v0.15.6.
pyproject.toml Version bump from 0.8.28dev1 to 0.8.29dev1; ruff pre-commit hook updated from v0.15.1 to v0.15.6.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR #6182 - 0.8.29dev1] --> B[Dependency Updates]
    A --> C[New Lucide Icons]
    A --> D[Docstring Reordering]
    A --> E[Code Cleanups]

    B --> B1[vite: rolldown-vite 7.3.1 → vite 8.0.0]
    B --> B2[React 19.2.3 → 19.2.4]
    B --> B3[React Router 7.13.0 → 7.13.1]
    B --> B4[Bun 1.3.9 → 1.3.10]
    B --> B5[recharts 3.7.0 → 3.8.0]
    B --> B6[plotly.js 3.3.1 → 3.4.0]
    B --> B7[tailwindcss 4.1.18 → 4.2.1]
    B --> B8[lucide-react 0.574.0 → 0.577.0]

    C --> C1[ellipse, fishing_rod, metronome]
    C --> C2[mouse_right, message_square_check]
    C --> C3[square_arrow_right_enter/exit]
    C --> C4[square_centerline_dashed_h/v]
    C --> C5[Removed: commented-out mouse_right]

    E --> E1[StateManagerMemory: yield directly]
    E --> E2[Remove noqa RUF036 comments]
    E --> E3[ruff v0.15.1 → v0.15.6]
Loading

Last reviewed commit: cf0bd65

Comment thread reflex/app.py
@adhami3310 adhami3310 changed the title 0829dev 090dev Mar 19, 2026
Comment on lines 162 to 163
# This should always match the `react` version in DEPENDENCIES for recharts compatibility.
"react-is": _react_version,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# This should always match the `react` version in DEPENDENCIES for recharts compatibility.
"react-is": _react_version,

no longer needed in recharts 3

@adhami3310 adhami3310 merged commit 7f5fdcc into main Mar 19, 2026
47 checks passed
@adhami3310 adhami3310 deleted the 0829dev branch March 19, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants