Skip to content

specify directories for publish#6282

Merged
adhami3310 merged 1 commit intomainfrom
specify-directories-for-publish
Apr 4, 2026
Merged

specify directories for publish#6282
adhami3310 merged 1 commit intomainfrom
specify-directories-for-publish

Conversation

@adhami3310
Copy link
Copy Markdown
Member

No description provided.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 4, 2026

Greptile Summary

This PR fixes the publish.yml GitHub Actions workflow by explicitly routing build artifacts to a consistent dist/ directory at the repository root (via --out-dir dist) and then publishing from dist/* instead of relying on uv publish --directory to locate them.

Key changes:

  • Build step: Adds --out-dir dist so that both the main reflex package and any sub-packages (e.g. packages/reflex-lucide) write their wheel and sdist to the same dist/ folder at the repo root.
  • Publish step: Switches from uv publish --directory \"${{ steps.parse.outputs.build_dir }}\" to uv publish dist/*, making it explicit which files are published and eliminating any ambiguity about where uv publish --directory looks for built artifacts.
  • The existing Verify .pyi files in wheel step was already referencing dist/*.whl, so this change makes the whole workflow internally consistent.

Confidence Score: 5/5

Safe to merge — the change is a straightforward fix that makes the build and publish steps internally consistent.

Both changes are small and correct: --out-dir dist ensures all build artifacts land in a predictable location regardless of which package is being built, and uv publish dist/* explicitly targets those artifacts. No logic, security, or data issues introduced.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/publish.yml Build step now outputs to a consistent dist/ directory at repo root via --out-dir dist, and publish step uses the explicit dist/* glob — fixing a likely bug where sub-package builds placed artifacts in packages/<name>/dist/ instead of the root dist/ that the publish step expected.

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions
    participant UV as uv CLI
    participant FS as Filesystem (dist/)
    participant PyPI as PyPI

    GH->>UV: uv build --directory $build_dir --out-dir dist
    UV->>FS: Write wheel + sdist to dist/ (repo root)
    GH->>FS: Verify dist/*.whl contains .pyi files (reflex only)
    GH->>UV: uv publish dist/*
    UV->>PyPI: Upload all artifacts from dist/
Loading

Reviews (1): Last reviewed commit: "specify directories for publish" | Re-trigger Greptile

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 4, 2026

Merging this PR will not alter performance

✅ 8 untouched benchmarks


Comparing specify-directories-for-publish (210b625) with main (d13a404)

Open in CodSpeed

@adhami3310 adhami3310 merged commit d3a2325 into main Apr 4, 2026
38 of 40 checks passed
@adhami3310 adhami3310 deleted the specify-directories-for-publish branch April 4, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants