fix double docs/ route on os templates

[carlosabadia]

No description provided.

[codspeed-hq]

Merging this PR will not alter performance

✅ 9 untouched benchmarks

---

_{Comparing carlos/fix-some-pages (eac2a47) with main (3fdcaf4)¹}

Footnotes

1. No successful run was found on main (eb43df4) during the generation of this report, so 3fdcaf4 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[greptile-apps]

Greptile Summary

This PR fixes a double docs/ segment in the URL routes for open-source template pages by updating base_url and back_route_origin in apps.py, and replaces rx.link with rx.el.elements.a in two places. However, two href values that still reference the old /docs/getting-started/open-source-templates/ path were not updated, leaving the gallery image links and the "View All" button pointing at broken URLs.

• code_card.py line 144: href=f\"/docs/getting-started/open-source-templates/{slug}\" should be /getting-started/open-source-templates/{slug}.
• apps.py line 129: href=\"/docs/getting-started/open-source-templates/\" should be /getting-started/open-source-templates/.

Confidence Score: 3/5

Not safe to merge — two href values were missed in the route-prefix cleanup, leaving gallery card and "View All" links broken.

Two P1 findings: the gallery image link and the "View All" button both still point to the removed /docs/ prefixed routes, meaning users clicking those links will land on a broken page. The route registration itself is fixed, so the destination pages exist at the correct path — only the hardcoded hrefs are wrong.

Both changed files need attention: code_card.py (line 144) and apps.py (line 129) each have a stale /docs/ href that must be corrected.

Important Files Changed

Filename	Overview
packages/reflex-site-shared/src/reflex_site_shared/components/code_card.py	Changed rx.link to rx.el.elements.a for the gallery card image link, but the href still references the old /docs/getting-started/open-source-templates/{slug} path that was removed by this PR.
packages/reflex-site-shared/src/reflex_site_shared/gallery/apps.py	Fixed route registration and back_route_origin to drop /docs/ prefix, and swapped rx.link for rx.el.elements.a; but the "View All" href in more_posts() still uses the old /docs/ path, and underline="none" is now an invalid HTML attribute on the raw <a> element.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Open Source Templates Gallery] -->|gallery_app_card href| B{"/docs/getting-started/...\n❌ stale path"}
    A -->|more_posts 'View All' href| C{"/docs/getting-started/...\n❌ stale path"}
    A -->|route registration base_url| D["/getting-started/open-source-templates/\n✅ fixed"]
    A -->|back_route_origin| E["/getting-started/open-source-templates/\n✅ fixed"]
    B -.->|broken link| F[404 / wrong page]
    C -.->|broken link| F

Loading

Comments Outside Diff (3)

1. packages/reflex-site-shared/src/reflex_site_shared/components/code_card.py, line 144 (link)

   Stale /docs/ prefix in href not updated

   The route for open-source templates was changed from docs/getting-started/open-source-templates/ to getting-started/open-source-templates/ in apps.py, but this href was not updated to match. Clicking the image in the gallery card will navigate to a broken URL.

2. packages/reflex-site-shared/src/reflex_site_shared/gallery/apps.py, line 129 (link)

   Stale /docs/ prefix in "View All" href

   The back_route_origin and the route registration loop were both fixed to drop the /docs/ segment, but this href in more_posts() still points to the old path. The "View All" button will navigate to a broken URL.

3. packages/reflex-site-shared/src/reflex_site_shared/gallery/apps.py, line 128 (link)

   underline is not a valid HTML attribute on rx.el.elements.a

   underline="none" is a rx.link-specific prop handled by Reflex's styled link component. Passing it to a raw HTML <a> element renders <a underline="none"> in the DOM, which browsers silently ignore, so the underline styling may reappear. Use CSS instead, e.g. class_name="no-underline" or style={"text_decoration": "none"}.

_{Reviews (1): Last reviewed commit: "remove open external" | Re-trigger Greptile}