fix(docs): align sidebar_comp signature with sidebar caller#6416
Closed
BABTUNA wants to merge 1 commit intoreflex-dev:mainfrom
Closed
fix(docs): align sidebar_comp signature with sidebar caller#6416BABTUNA wants to merge 1 commit intoreflex-dev:mainfrom
BABTUNA wants to merge 1 commit intoreflex-dev:mainfrom
Conversation
Contributor
Greptile SummaryThis PR removes the stale Confidence Score: 5/5Safe to merge — the change removes a dead parameter that was never supplied or used. Single-line removal of an unused required parameter with a matching regression test; no logic change, no data path affected. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Caller as sidebar(url)
participant Comp as sidebar_comp(...)
Note over Caller: Computes all index lists<br/>(learn_index, component_lib_index, …)
Caller->>Comp: sidebar_comp(url, learn_index, …, skills_index, width)
Note over Comp: Before PR: required tutorials_index<br/>After PR: parameter removed
Comp-->>Caller: rx.Component
Reviews (1): Last reviewed commit: "fix(docs): remove stale tutorials_index ..." | Re-trigger Greptile |
Member
|
Thats for the pr but I dont think we need this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:\n\n- [x] Have you followed the guidelines stated in CONTRIBUTING.md file?\n- [x] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?\n\n### Type of change\n\n- [x] Bug fix (non-breaking change which fixes an issue)\n\n### Changes To Core Features:\n\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\n- [x] Have you written new tests for your core changes, as applicable?\n- [x] Have you successfully ran tests with your changes locally?\n\n### Description\n\nFollow-up to #6359 to fix a sidebar API mismatch in docs.\n\nBefore this change, sidebar_comp(...) required a utorials_index parameter, but the only call site in sidebar(...) never passed it. That parameter was also unused in the implementation.\n\nThis PR removes the stale required argument so the function signature and caller stay aligned.\n\n### Tests\n\nAdded regression test:\n- docs/app/tests/test_sidebar.py::test_sidebar_renders_without_tutorials_index_arg\n\nValidation run:\n- uv run ruff check docs/app/reflex_docs/templates/docpage/sidebar/sidebar.py docs/app/tests/test_sidebar.py\n- uv run pytest docs/app/tests/test_sidebar.py -q\n- uv run pytest tests/test_routes.py -q (from docs/app)\n