Skip to content

Fix wrong Blog and FAQ links in docs footer#6731

Merged
carlosabadia merged 3 commits into
mainfrom
codex/fix-docs-footer-blog
Jul 10, 2026
Merged

Fix wrong Blog and FAQ links in docs footer#6731
carlosabadia merged 3 commits into
mainfrom
codex/fix-docs-footer-blog

Conversation

@carlosabadia

Copy link
Copy Markdown
Contributor

No description provided.

@carlosabadia carlosabadia requested a review from Alek99 as a code owner July 10, 2026 15:29
@carlosabadia carlosabadia added the skip-changelog For doc/internal changes label Jul 10, 2026
@carlosabadia carlosabadia requested a review from a team as a code owner July 10, 2026 15:29
@greptile-apps

greptile-apps Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes footer links that should leave the docs router. The main changes are:

  • Adds a root_site mode to docs footer links.
  • Renders Blog and FAQ as raw root-site anchors.
  • Adds a route test for the Blog and FAQ footer hrefs.

Confidence Score: 5/5

This looks safe to merge after checking the standalone docs deployment path.

  • No blocking issues found in the changed code.
  • The only follow-up is a deployment-shape check for root /blog/ and /faq/ routes.

Important Files Changed

Filename Overview
docs/app/reflex_docs/templates/docpage/docpage.py Adds root-site anchor rendering for Blog and FAQ while keeping other footer links on the docs router.
docs/app/tests/test_routes.py Adds a focused test that renders the footer and checks Blog and FAQ use raw anchor hrefs.

Reviews (1): Last reviewed commit: "and this" | Re-trigger Greptile

Comment thread docs/app/reflex_docs/templates/docpage/docpage.py
@codspeed-hq

codspeed-hq Bot commented Jul 10, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 26 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing codex/fix-docs-footer-blog (b999d4d) with main (948c619)2

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (3b97060) during the generation of this report, so 948c619 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@carlosabadia carlosabadia merged commit 9a5c4d3 into main Jul 10, 2026
108 checks passed
@carlosabadia carlosabadia deleted the codex/fix-docs-footer-blog branch July 10, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants