Add note about requesting semantics#508
Merged
Merged
Conversation
|
#505 |
Contributor
|
I have recently had a similar issue. In my opinion users of the class shouldn’t make any assumptions about the timing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be the case for Obelisk's HTTP requester. Should it be true in general? Is this the right place to document it?
Being explicit about this matters to me, because it's possible to implement a requester has the request and response events fire at the same time. If that were the case, then you wouldn't be able to, say, transition a DOM element to "loading" while a request was in flight.