Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ protected EncryptedRCLItem() { }
/// </summary>
/// <value>Base64 encoded data</value>
/*
<example>[B@671e627</example>
<example>[B@71ccb5a9</example>
*/
[DataMember(Name = "EncryptedRCL", IsRequired = true, EmitDefaultValue = true)]
public byte[] EncryptedRCL { get; set; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
/// </summary>
/// <value>Base64 encoded data</value>
/*
<example>[B@671e627</example>
<example>[B@71ccb5a9</example>
*/
[DataMember(Name = "EncryptedRCL", IsRequired = true, EmitDefaultValue = true)]
public byte[] EncryptedRCL { get; set; }
Expand Down Expand Up @@ -105,7 +105,7 @@
/// </summary>
/// <param name="validationContext">Validation context</param>
/// <returns>Validation Result</returns>
protected IEnumerable<ValidationResult> BaseValidate(ValidationContext validationContext)

Check warning on line 108 in src/Regula.DocumentReader.WebClient/Model/EncryptedRCLResult.cs

View workflow job for this annotation

GitHub Actions / run_smoke_test

'EncryptedRCLResult.BaseValidate(ValidationContext)' hides inherited member 'ResultItem.BaseValidate(ValidationContext)'. Use the new keyword if hiding was intended.
{
foreach (var x in base.BaseValidate(validationContext))
{
Expand Down
34 changes: 12 additions & 22 deletions src/Regula.DocumentReader.WebClient/Model/FDSIDList.cs
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,13 @@ protected FDSIDList() { }
/// Initializes a new instance of the <see cref="FDSIDList" /> class.
/// </summary>
/// <param name="iCAOCode">ICAO code of the issuing country (required).</param>
/// <param name="count">Number of elements in the List (required).</param>
/// <param name="list">Document identifiers in &#39;Information Reference Systems&#39; (required).</param>
/// <param name="count">Number of elements in the List.</param>
/// <param name="list">Document identifiers in &#39;Information Reference Systems&#39;.</param>
/// <param name="dType">dType (required).</param>
/// <param name="dFormat">dFormat (required).</param>
/// <param name="dMRZ">Flag indicating the presence of MRZ on the document (required).</param>
/// <param name="dDescription">Document description.</param>
/// <param name="dYear">Year of publication of the document (required).</param>
/// <param name="dYear">Year of publication of the document.</param>
/// <param name="dCountryName">Issuing country name (required).</param>
/// <param name="dStateCode">Issuing state code.</param>
/// <param name="dStateName">Issuing state name.</param>
Expand All @@ -72,30 +72,20 @@ protected FDSIDList() { }
throw new ArgumentNullException("iCAOCode is a required property for FDSIDList and cannot be null");
}
this.ICAOCode = iCAOCode;
this.Count = count;
// to ensure "list" is required (not null)
if (list == null)
{
throw new ArgumentNullException("list is a required property for FDSIDList and cannot be null");
}
this.List = list;
this.DType = dType;
this.DFormat = dFormat;
this.DMRZ = dMRZ;
// to ensure "dYear" is required (not null)
if (dYear == null)
{
throw new ArgumentNullException("dYear is a required property for FDSIDList and cannot be null");
}
this.DYear = dYear;
// to ensure "dCountryName" is required (not null)
if (dCountryName == null)
{
throw new ArgumentNullException("dCountryName is a required property for FDSIDList and cannot be null");
}
this.DCountryName = dCountryName;
this.IsDeprecated = isDeprecated;
this.Count = count;
this.List = list;
this.DDescription = dDescription;
this.DYear = dYear;
this.DStateCode = dStateCode;
this.DStateName = dStateName;
}
Expand All @@ -111,15 +101,15 @@ protected FDSIDList() { }
/// Number of elements in the List
/// </summary>
/// <value>Number of elements in the List</value>
[DataMember(Name = "Count", IsRequired = true, EmitDefaultValue = true)]
public decimal Count { get; set; }
[DataMember(Name = "Count", EmitDefaultValue = false)]
public decimal? Count { get; set; }

/// <summary>
/// Document identifiers in &#39;Information Reference Systems&#39;
/// </summary>
/// <value>Document identifiers in &#39;Information Reference Systems&#39;</value>
[DataMember(Name = "List", IsRequired = true, EmitDefaultValue = true)]
public List<int> List { get; set; }
[DataMember(Name = "List", EmitDefaultValue = false)]
public List<int>? List { get; set; }

/// <summary>
/// Flag indicating the presence of MRZ on the document
Expand All @@ -139,8 +129,8 @@ protected FDSIDList() { }
/// Year of publication of the document
/// </summary>
/// <value>Year of publication of the document</value>
[DataMember(Name = "dYear", IsRequired = true, EmitDefaultValue = true)]
public string DYear { get; set; }
[DataMember(Name = "dYear", EmitDefaultValue = false)]
public string? DYear { get; set; }

/// <summary>
/// Issuing country name
Expand Down
2 changes: 1 addition & 1 deletion src/Regula.DocumentReader.WebClient/Model/LicenseItem.cs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ protected LicenseItem() { }
/// </summary>
/// <value>Base64 encoded data</value>
/*
<example>[B@3768c9b</example>
<example>[B@6511807b</example>
*/
[DataMember(Name = "License", IsRequired = true, EmitDefaultValue = true)]
public byte[] License { get; set; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ protected LicenseResult() { }
/// </summary>
/// <value>Base64 encoded data</value>
/*
<example>[B@3768c9b</example>
<example>[B@6511807b</example>
*/
[DataMember(Name = "License", IsRequired = true, EmitDefaultValue = true)]
public byte[] License { get; set; }
Expand Down
Loading