Skip to content

.disconnect() method and constructor structure #15

@bilgin1500

Description

@bilgin1500

Thanks for the hook implementation.

A concern about disconnect method: MDN docs say that the disconnect method doesn't receive any parameters, it rather disconnects all the connected observers.

A question about the constructor: I think the code creates a new constructor every time a new ref is given. Please correct me if I'm wrong, but given the fact that we always use the same handleResize callback, shouldn't we use a single global ResizeObserver reference?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions