Skip to content

transpiling to es5#22

Merged
fouad merged 1 commit into
rehooks:masterfrom
unchai:master
Jun 19, 2019
Merged

transpiling to es5#22
fouad merged 1 commit into
rehooks:masterfrom
unchai:master

Conversation

@unchai

@unchai unchai commented Jun 17, 2019

Copy link
Copy Markdown

fix #18

@fouad fouad merged commit f04a2f0 into rehooks:master Jun 19, 2019
@slorber

slorber commented Jul 18, 2019

Copy link
Copy Markdown

hi,

sorry but not sure exactly how you did transpile the lib.

Isn't there a pipeline to transpile from source to target?

What if someone later add a const, will you think about transpiling again?

Asking because the lib did fail for me in IE11 and was not easy to track down what was the cause, and don't want it to happen again, but the process here makes me feel it's likely to happen again

@unchai

unchai commented Jul 19, 2019

Copy link
Copy Markdown
Author

@slorber You are right. It can happen again. I can't even do it manually every time. So I added a transpiling pipeline. (#23). I hope that will be merged. 😄

@slorber

slorber commented Jul 19, 2019

Copy link
Copy Markdown

great thanks for making this more sustainable ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Babel compiled output contains LET

3 participants