feat: surface HTTP status code in onNext metadata#61
Merged
Conversation
onNext already receives a metadata arg ({ responseHeaders } on the fetch
transport), but not the HTTP status. A non-2xx JSON response (e.g. a 401)
parses successfully, so it is delivered through onNext — not onError — with
the status discarded. Consumers therefore cannot distinguish a 401 from a
normal GraphQL response and cannot react to auth failures.
Add `status` to the onNext metadata on both transports:
- fetch.js: response.status (multipart onResponse + json branches)
- xhr.js: xhr.status (multipart onResponse + json branch)
- typings.d.ts: type the previously-untyped onNext metadata arg
({ responseHeaders?: Headers; status?: number }).
robrichard
approved these changes
Jun 25, 2026
Member
|
Thanks! |
robrichard
pushed a commit
that referenced
this pull request
Jun 29, 2026
onNext already receives a metadata arg ({ responseHeaders } on the fetch
transport), but not the HTTP status. A non-2xx JSON response (e.g. a 401)
parses successfully, so it is delivered through onNext — not onError — with
the status discarded. Consumers therefore cannot distinguish a 401 from a
normal GraphQL response and cannot react to auth failures.
Add `status` to the onNext metadata on both transports:
- fetch.js: response.status (multipart onResponse + json branches)
- xhr.js: xhr.status (multipart onResponse + json branch)
- typings.d.ts: type the previously-untyped onNext metadata arg
({ responseHeaders?: Headers; status?: number }).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60
onNext already receives a metadata arg ({ responseHeaders } on the fetch transport), but not the HTTP status. A non-2xx JSON response (e.g. a 401) parses successfully, so it is delivered through onNext — not onError — with the status discarded. Consumers therefore cannot distinguish a 401 from a normal GraphQL response and cannot react to auth failures.
Add
statusto the onNext metadata on both transports: