Error should not be thrown on HTTP error when noThrow is set.#123
Open
Dirklectisch wants to merge 1 commit into
Open
Error should not be thrown on HTTP error when noThrow is set.#123Dirklectisch wants to merge 1 commit into
Dirklectisch wants to merge 1 commit into
Conversation
|
I seem to be not having any luck with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the noThrow flag only disable throwing for GraphQL errors in the response. For HTTP errors codes coming back from the server an error will be thrown currently even though you set the flag.
In my opinion it makes sense to do the same for HTTP errors in the response. You either handle all the errors yourself or you let the middleware stack throw errors.