Skip to content

Set spec.params instead of pipelineSpec.params #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asergienk merged 1 commit into from
Jun 26, 2026
Merged

Set spec.params instead of pipelineSpec.params #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .tekton/fbc-update-planner-pull-request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ spec:
value: Dockerfile
- name: prefetch-input
value: '{"type": "gomod", "path": "."}'
- name: hermetic

@fullsend-ai-review fullsend-ai-review Bot Jun 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] undocumented-convention

The PR body references a 'Konflux convention' for placing defaults in pipelineSpec.params with overrides in spec.params. This convention is not documented in the repository. However, this is a well-known Konflux platform pattern and the .tekton pipeline files are platform-managed artifacts.

Suggested fix: Optionally add a comment in the YAML or a brief note in project docs about Konflux pipeline configuration conventions.

value: "true"
- name: build-source-image
value: "true"
pipelineSpec:
description: |
This pipeline is ideal for building container images from a Containerfile while maintaining trust after pipeline customization.
Expand Down Expand Up @@ -61,7 +65,7 @@ spec:
description: Skip checks against built image
name: skip-checks
type: string
- default: "true"
- default: "false"
description: Execute the build with network isolation
name: hermetic
type: string
Expand All @@ -74,7 +78,7 @@ spec:
1h, 2d, 3w for hours, days, and weeks, respectively.
name: image-expires-after
type: string
- default: "true"
- default: "false"
description: Build a source image.
name: build-source-image
type: string
Expand Down Expand Up @@ -155,7 +159,7 @@ spec:
- name: name
value: git-clone-oci-ta
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-git-clone-oci-ta:0.1@sha256:d30f13dd15daf89dd6dc645243b3444d35570d13f7840c3fd65e366022515205
value: quay.io/konflux-ci/tekton-catalog/task-git-clone-oci-ta:0.1@sha256:e865b49436c38a0ce41c7d9e726143b2025dea23e9f782b4821f9db8a0e4b625
- name: kind
value: task
resolver: bundles
Expand Down
10 changes: 7 additions & 3 deletions .tekton/fbc-update-planner-push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ spec:
value: Dockerfile
- name: prefetch-input
value: '{"type": "gomod", "path": "."}'
- name: hermetic
value: "true"
- name: build-source-image
value: "true"
pipelineSpec:
description: |
This pipeline is ideal for building container images from a Containerfile while maintaining trust after pipeline customization.
Expand Down Expand Up @@ -58,7 +62,7 @@ spec:
description: Skip checks against built image
name: skip-checks
type: string
- default: "true"
- default: "false"
description: Execute the build with network isolation
name: hermetic
type: string
Expand All @@ -71,7 +75,7 @@ spec:
1h, 2d, 3w for hours, days, and weeks, respectively.
name: image-expires-after
type: string
- default: "true"
- default: "false"
description: Build a source image.
name: build-source-image
type: string
Expand Down Expand Up @@ -152,7 +156,7 @@ spec:
- name: name
value: git-clone-oci-ta
- name: bundle
value: quay.io/konflux-ci/tekton-catalog/task-git-clone-oci-ta:0.1@sha256:d30f13dd15daf89dd6dc645243b3444d35570d13f7840c3fd65e366022515205
value: quay.io/konflux-ci/tekton-catalog/task-git-clone-oci-ta:0.1@sha256:e865b49436c38a0ce41c7d9e726143b2025dea23e9f782b4821f9db8a0e4b625
- name: kind
value: task
resolver: bundles
Expand Down
Loading