Skip to content

Commit ce28701

Browse files
rem1776rem1776
authored andcommitted
fix any serial failures from diag_manager and mpp
1 parent a9c59ee commit ce28701

16 files changed

Lines changed: 25 additions & 17 deletions

test_fms/diag_manager/Makefile.am

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ else
105105
ncdump_skip=""
106106
endif
107107

108-
if SKIP_PARALLEL_TEST
108+
if SERIAL_BUILD
109109
parallel_skip="skip"
110110
else
111111
parallel_skip=""

test_fms/diag_manager/test_diag_manager2.sh

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1336,10 +1336,13 @@ diag_files:
13361336
...
13371337
_EOF
13381338

1339-
my_test_count=`expr $my_test_count + 1`
1340-
test_expect_success "check modern diag manager yaml output (test $my_test_count)" '
1341-
mpirun -n 1 ../test_diag_out_yaml
1342-
'
1339+
# skip if mpi is disabled, previous test is parallel so no output to check
1340+
if [ -z "${parallel_skip}" ]; then
1341+
my_test_count=`expr $my_test_count + 1`
1342+
test_expect_success "check modern diag manager yaml output (test $my_test_count)" '
1343+
mpirun -n 1 ../test_diag_out_yaml
1344+
'
1345+
fi
13431346

13441347
printf "&diag_manager_nml \n use_modern_diag = .true. \n use_clock_average = .true. \n /" | cat > input.nml
13451348
cat <<_EOF > diag_table.yaml

test_fms/diag_manager/test_subregional.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
# Set common test settings.
2222
. ../test-lib.sh
2323

24-
if [ -z "${parser_skip}" ]; then
24+
if [ -z "${parser_skip}" ] && [ -z "${parallel_skip}" ]; then
2525
# create and enter directory for in/output files
2626
output_dir
2727

test_fms/diag_manager/test_time_avg.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
# Set common test settings.
2222
. ../test-lib.sh
2323

24-
if [ -z "${parser_skip}" ]; then
24+
if [ -z "${parser_skip}" ] && [ -z "${parallel_skip}" ]; then
2525
# create and enter directory for in/output files
2626
output_dir
2727

test_fms/diag_manager/test_time_diurnal.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
# Set common test settings.
2222
. ../test-lib.sh
2323

24-
if [ -z "${parser_skip}" ]; then
24+
if [ -z "${parser_skip}" ] && [ -z "${parallel_skip}" ]; then
2525
# create and enter directory for in/output files
2626
output_dir
2727

test_fms/diag_manager/test_time_max.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
# Set common test settings.
2424
. ../test-lib.sh
2525

26-
if [ -z "${parser_skip}" ]; then
26+
if [ -z "${parser_skip}" ] && [ -z "${parallel_skip}" ]; then
2727
# create and enter directory for in/output files
2828
output_dir
2929

test_fms/diag_manager/test_time_min.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
# Set common test settings.
2424
. ../test-lib.sh
2525

26-
if [ -z "${parser_skip}" ]; then
26+
if [ -z "${parser_skip}" ] && [ -z "${parallel_skip}" ]; then
2727
# create and enter directory for in/output files
2828
output_dir
2929

test_fms/diag_manager/test_time_none.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
# Set common test settings.
2424
. ../test-lib.sh
2525

26-
if [ -z "${parser_skip}" ]; then
26+
if [ -z "${parser_skip}" ] && [ -z "${parallel_skip}" ]; then
2727
# create and enter directory for in/output files
2828
output_dir
2929

test_fms/diag_manager/test_time_pow.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
# Set common test settings.
2222
. ../test-lib.sh
2323

24-
if [ -z "${parser_skip}" ]; then
24+
if [ -z "${parser_skip}" ] && [ -z "${parallel_skip}" ]; then
2525
# create and enter directory for in/output files
2626
output_dir
2727

test_fms/diag_manager/test_time_rms.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
# Set common test settings.
2222
. ../test-lib.sh
2323

24-
if [ -z "${parser_skip}" ]; then
24+
if [ -z "${parser_skip}" ] && [ -z "${parallel_skip}" ]; then
2525
# create and enter directory for in/output files
2626
output_dir
2727

0 commit comments

Comments
 (0)