refactor: fix lint and type errors

remarkablemark · remarkablemark · commit d53a32da538b · 2026-01-30T01:42:37.000-05:00
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -39,7 +39,7 @@ export default defineConfig([
         ...globals.node,
       },
       parserOptions: {
-        project: ['tsconfig.json', 'tsconfig.test.json'],
+        project: ['tsconfig.build.json', 'tsconfig.test.json'],
         tsconfigRootDir: import.meta.dirname,
       },
     },
diff --git a/karma.conf.js b/karma.conf.js
@@ -1,5 +1,7 @@
 /**
  * @see https://karma-runner.github.io/6.4/config/configuration-file.html
+ *
+ * @param {{LOG_INFO: string; set: () => void}} config
  */
 module.exports = (config) => {
   config.set({
diff --git a/package.json b/package.json
@@ -34,7 +34,7 @@
   },
   "scripts": {
     "build": "run-s build:*",
-    "build:cjs": "tsc",
+    "build:cjs": "tsc --project tsconfig.build.json",
     "build:esm": "rollup --config --failAfterWarnings --environment ESM:true && scripts/fix-esm.sh",
     "build:umd": "rollup --config --failAfterWarnings --environment UMD:true",
     "clean": "rm -rf .nyc_output coverage dist esm lib",
diff --git a/rollup.config.mjs b/rollup.config.mjs
@@ -8,7 +8,7 @@ import typescript from '@rollup/plugin-typescript';
 
 const require = createRequire(import.meta.url);
 
-const getPlugins = ({ browser = false, minify = false, outDir }) =>
+const getPlugins = ({ browser = false, minify = false, outDir = '' }) =>
   [
     browser &&
       alias({
@@ -20,6 +20,7 @@ const getPlugins = ({ browser = false, minify = false, outDir }) =>
         ],
       }),
     typescript({
+      tsconfig: 'tsconfig.build.json',
       compilerOptions: {
         module: 'esnext',
         outDir,
diff --git a/src/client/utilities.ts b/src/client/utilities.ts
@@ -121,19 +121,20 @@ export function formatDOM(
       }
 
       case 3:
-        current = new Text(revertEscapedCharacters(node.nodeValue!));
+        current = new Text(revertEscapedCharacters(node.nodeValue ?? ''));
         break;
 
       case 8:
-        current = new Comment(node.nodeValue!);
+        current = new Comment(node.nodeValue ?? '');
         break;
 
       default:
         continue;
     }
 
     // set previous node next
-    const prev = domNodes[index - 1] || null;
+    const prev = domNodes[index - 1] ?? null;
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
     if (prev) {
       prev.next = current;
     }
@@ -152,7 +153,7 @@ export function formatDOM(
       directive,
     );
 
-    current.next = domNodes[0] || null;
+    current.next = domNodes[0] ?? null;
     current.parent = parent as Element;
     domNodes.unshift(current);
 
diff --git a/test/cases/index.js b/test/cases/index.js
@@ -1,6 +1,9 @@
-const fs = require('fs');
-const path = require('path');
+const fs = require('node:fs');
+const path = require('node:path');
+
+// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 const { minify } = require('html-minifier');
+
 const htmlCases = require('./html');
 
 /**
@@ -17,6 +20,7 @@ const html = [
   ...htmlCases,
   {
     name: 'complex html',
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call
     data: minify(read('./complex.html'), {
       collapseWhitespace: true,
     }),
diff --git a/test/client/index.js b/test/client/index.js
@@ -1,3 +1,5 @@
+/* eslint-disable */
+
 const htmlCases = require('../cases/html');
 const serverParser = require('../../dist/htmlparser2').parseDOM;
 const clientParser = require('../../dist/html-dom-parser');
diff --git a/test/helpers/cycle.js b/test/helpers/cycle.js
@@ -1,3 +1,5 @@
+/* eslint-disable */
+
 /**
  * @see {@link https://github.com/douglascrockford/JSON-js/blob/master/cycle.js}
  */
@@ -142,7 +144,7 @@ if (typeof JSON.retrocycle !== 'function') {
     // produces an array containing a single element which is the array itself.
 
     var px =
-      /^\$(?:\[(?:\d+|"(?:[^\\"\u0000-\u001f]|\\(?:[\\"/bfnrt]|u[0-9a-zA-Z]{4}))*")\])*$/; // eslint-disable-line no-control-regex
+      /^\$(?:\[(?:\d+|"(?:[^\\"\u0000-\u001f]|\\(?:[\\"/bfnrt]|u[0-9a-zA-Z]{4}))*")\])*$/;
 
     (function rez(value) {
       // The rez function walks recursively through the object looking for $ref
diff --git a/test/helpers/run-tests.js b/test/helpers/run-tests.js
@@ -6,10 +6,10 @@ const isKarma =
 /**
  * Runs tests.
  *
- * @param {Function} assert         - Assert.
- * @param {Object}   testCases      - Test cases.
- * @param {Function} actualParser   - Actual parser.
- * @param {Function} expectedParser - Expected parser.
+ * @param {{deepEqual: () => void}} assert
+ * @param {Record<string, string>[]} testCases
+ * @param {() => object} actualParser
+ * @param {() => object} expectedParser
  */
 module.exports = function runTests(
   assert,
@@ -27,7 +27,9 @@ module.exports = function runTests(
       // use `JSON.decycle` since `assert.deepEqual` fails
       // when instance types are different in the browser
       if (isKarma) {
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-assignment
         actualOutput = JSON.decycle(actualOutput);
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-assignment
         expectedOutput = JSON.decycle(expectedOutput);
       }
 
diff --git a/test/helpers/test-case-sensitive-tags.js b/test/helpers/test-case-sensitive-tags.js
@@ -3,7 +3,8 @@ const constants = require('../../lib/client/constants');
 /**
  * Tests case-sensitive tags (SVG) to make sure their case is preserved.
  *
- * @param {Function} parser - The parser.
+ * @param {{equal: () => void}} assert
+ * @param {() => object[]} parser
  */
 module.exports = function testCaseSensitiveTags(assert, parser) {
   it('preserves case of case-sensitive SVG tags', () => {
diff --git a/test/helpers/throw-errors.js b/test/helpers/throw-errors.js
@@ -7,15 +7,16 @@ const values = [
   false,
   {},
   [],
+  // eslint-disable-next-line @typescript-eslint/no-empty-function
   () => {},
   new Date(),
 ];
 
 /**
  * Calls parser with invalid arguments.
  *
- * @param {Function} assert         - Assert.
- * @param {Function} expectedParser - Expected parser.
+ * @param {{throws: () => void}} assert
+ * @param {() => object} expectedParser
  */
 module.exports = function throwErrors(assert, expectedParser) {
   values.forEach((value) => {
diff --git a/test/server/server.test.ts b/test/server/server.test.ts
@@ -1,28 +1,34 @@
 import { assert } from 'chai';
 import * as htmlparser from 'htmlparser2';
-// @ts-ignore
 import jsdomify from 'jsdomify';
 
 import serverParser from '../../src';
 import cases from '../cases';
 import { runTests, testCaseSensitiveTags, throwErrors } from '../helpers';
 
+const parseDOM = (data: string, options: htmlparser.Options) =>
+  htmlparser.parseDocument(data, options).children;
+
 describe('server parser', () => {
   throwErrors(assert, serverParser);
-  runTests(assert, serverParser, htmlparser.parseDOM, cases.html);
-  runTests(assert, serverParser, htmlparser.parseDOM, cases.svg);
+
+  runTests(assert, serverParser, parseDOM, cases.html);
+  runTests(assert, serverParser, parseDOM, cases.svg);
 
   // TODO: case-sensitive (SVG) tags are not preserved in server parser
   // testCaseSensitiveTags(assert, serverParser);
 });
 
 describe('client parser in jsdom', () => {
   jsdomify.create();
-  const clientParser = require('../../src/client/html-to-dom').default;
+
+  const clientParser =
+    // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+    require('../../src/client/html-to-dom').default as unknown;
 
   throwErrors(assert, clientParser);
-  runTests(assert, clientParser, htmlparser.parseDOM, cases.html);
-  runTests(assert, clientParser, htmlparser.parseDOM, cases.svg);
+  runTests(assert, clientParser, parseDOM, cases.html);
+  runTests(assert, clientParser, parseDOM, cases.svg);
   testCaseSensitiveTags(assert, clientParser);
 
   after(() => {
diff --git a/test/types/jsdomify.d.ts b/test/types/jsdomify.d.ts
@@ -0,0 +1,10 @@
+declare module 'jsdomify' {
+  interface JsdomifyOptions {
+    html?: string;
+    url?: string;
+  }
+
+  export function create(options?: JsdomifyOptions): void;
+  export function destroy(): void;
+  export const jsdom: unknown;
+}
diff --git a/tsconfig.build.json b/tsconfig.build.json
@@ -0,0 +1,14 @@
+{
+  "compilerOptions": {
+    "target": "es5",
+    "module": "commonjs",
+    "lib": ["es5", "dom"],
+    "esModuleInterop": true,
+    "declaration": true,
+    "declarationMap": true,
+    "sourceMap": true,
+    "strict": true,
+    "outDir": "lib"
+  },
+  "include": ["src"]
+}
diff --git a/tsconfig.json b/tsconfig.json
@@ -1,14 +1,7 @@
 {
-  "compilerOptions": {
-    "target": "es5",
-    "module": "commonjs",
-    "lib": ["es5", "dom"],
-    "esModuleInterop": true,
-    "declaration": true,
-    "declarationMap": true,
-    "sourceMap": true,
-    "strict": true,
-    "outDir": "lib"
-  },
-  "include": ["src"]
+  "files": [],
+  "references": [
+    { "path": "./tsconfig.build.json" },
+    { "path": "./tsconfig.test.json" }
+  ]
 }
diff --git a/tsconfig.test.json b/tsconfig.test.json
@@ -1,7 +1,13 @@
 {
-  "extends": "./tsconfig.json",
+  "extends": "./tsconfig.build.json",
   "compilerOptions": {
     "allowJs": true
   },
-  "include": ["eslint.config.mjs", "test"]
+  "include": [
+    "src",
+    "test",
+    "eslint.config.mjs",
+    "karma.conf.js",
+    "rollup.config.mjs"
+  ]
 }

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+/* eslint-disable */`
	`2`	`+`
`1`	`3`	`const htmlCases = require('../cases/html');`
`2`	`4`	`const serverParser = require('../../dist/htmlparser2').parseDOM;`
`3`	`5`	`const clientParser = require('../../dist/html-dom-parser');`