Skip to content

migrate QuickDapp to subagent architecture + add fetch_figma_design M…#7208

Merged
yann300 merged 18 commits into
masterfrom
fix/quickdapp-review-comments
May 19, 2026
Merged

migrate QuickDapp to subagent architecture + add fetch_figma_design M…#7208
yann300 merged 18 commits into
masterfrom
fix/quickdapp-review-comments

Conversation

@hsy822
Copy link
Copy Markdown
Collaborator

@hsy822 hsy822 commented May 11, 2026

Summary

Responds to Stefan's PR review comments and call feedback. Migrates QuickDapp from direct LLM calling to agent-delegated subagent architecture.

PR Comments

  • "Use the current agent inferencer, this is creating a new model instance" → Removed direct model creation; subagent inherits model config
  • "Still parsing pages even though agent writes files automatically" → Removed parsePages() entirely
  • "No model setting, should inherit from user settings" → Subagent inherits model; no hardcoded model
  • writeFilesToWorkspace — most probably not needed anymore" → Removed
  • "callAIModel — not needed, use the agent" → Removed callAIModel() and callAIModelDirect()
  • "This constraint means the output needs to be parsed?" → Removed delimiter format rules from prompts
  • "You are calling the model, not the agent → need to post-process" → Root cause fixed by subagent delegation
  • "Settings for choosing models" → Subagent inherits model selection; dedicated settings UI not yet built
  • "Auto-approve / bypass checkbox for HITL"
  • "Create QuickDapp specialist sub-agent" → QuickDapp Specialist subagent created
  • Workspace path duplication prevention
  • Strengthen the prompt for the dApp wallet connection issue
  • Move the auto-accept checkbox into the approval modal.
  • Fix QuickDapp dashboard state cleanup on cancel/error paths

@hsy822 hsy822 added the WIP label May 11, 2026
@STetsing STetsing self-requested a review May 11, 2026 08:19
Copy link
Copy Markdown
Collaborator

@STetsing STetsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add persistent user selection preference on HITL. Selecting or asserting many times changes is painful. the user should be able to skip those changes by accepting every thing or fallback to the granulated setting as of now

Comment thread libs/remix-ai-core/src/inferencers/deepagent/deepAgentMiddleWare.ts Outdated
Comment thread libs/remix-ai-core/src/remix-mcp-server/RemixMCPServer.ts Outdated
@hsy822 hsy822 requested a review from STetsing May 12, 2026 07:50
@hsy822 hsy822 added ready-to-review PR ready to review and removed WIP labels May 13, 2026
Base automatically changed from lanchain_deepagent to master May 13, 2026 09:42
@netlify
Copy link
Copy Markdown

netlify Bot commented May 14, 2026

Deploy Preview for reliable-cocada-166884 ready!

Name Link
🔨 Latest commit fa8d8b1
🔍 Latest deploy log https://app.netlify.com/projects/reliable-cocada-166884/deploys/6a0c1c4a067bba0008664b18
😎 Deploy Preview https://deploy-preview-7208--reliable-cocada-166884.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 14, 2026

View your CI Pipeline Execution ↗ for commit fa8d8b1

Command Status Duration Result
nx build plugin_api --configuration=production ... ✅ Succeeded <1s View ↗
nx lint vyper ✅ Succeeded <1s View ↗
nx lint remixd ✅ Succeeded <1s View ↗
nx lint solhint ✅ Succeeded <1s View ↗
nx lint doc-gen ✅ Succeeded <1s View ↗
nx lint remix-ui ✅ Succeeded <1s View ↗
nx lint learneth ✅ Succeeded <1s View ↗
nx lint debugger ✅ Succeeded <1s View ↗
Additional runs (24) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2026-05-19 14:21:02 UTC

@ci-pr-comment
Copy link
Copy Markdown

ci-pr-comment Bot commented May 14, 2026

❌ E2E failures detected (workflow: web)

Last run: Tue, May 19, 2026, 02:33 PM UTC

View HTML report

Top failing tests (10/10):

  • Should click Ask RemixAI while debugging and open assistant on right side (debugger_group1.test)
  • clone a repo #group1 #group3 #group4 (dgit_local_group2.test)
  • check source control panel (workspace_git_group5.test)
  • Should create two workspace and switch to the first one (workspace_group1.test)
  • clone a repo #group1 #group2 #group4 (dgit_local_group3.test)
  • clone a repo #group2 #group3 #group4 (dgit_local_group1.test)
  • clone a repo #group1 #group2 #group3 (dgit_local_group4.test)
  • Format code (code_format.test)
  • check git for the commit (workspace_git_group1.test)
  • Should ensure that .states is not updated when save env option is unchecked (runAndDeploy_group5.test)

Report generated by CI; artifacts are retained per CircleCI retention settings.

hsy822 added 9 commits May 19, 2026 13:41
- SubagentConfig: register QuickDapp Specialist subagent
- lightPrompts: add QUICKDAPP_SPECIALIST_SUBAGENT_PROMPT
- DAppGeneratorHandler: restore subagent delegation (generate_dapp, update_dapp)
- DeepAgentInferencer: remove answerWithCustomSystemPrompt() dead code
- remixAIPlugin: remove DAppGenerationManager methods/imports
- remixAI/index.ts: remove DAppGenerationManager export
- Add hitlAutoAccept state, ref, toggle, and localStorage persistence
- Update handleApproveToolAction signature to accept options object
- Add auto-accept banner element in all 3 view modes
- Externalize inline styles to CSS classes (hitl-pending-summary, ai-chat-area-flat)
FigmaHandler.ts was deleted (fetch_figma_design inlined in DAppGeneratorHandler).
Remove dangling export to prevent compile errors.
- handleToolApproval: restore hitlAutoAcceptRef guard (auto-approve)
- cancelRequest: restore QuickDapp dashboard spinner cleanup
- nonMaximizedMode: restore ai-history-view-bg CSS class
- history heading: remove inline backgroundColor (externalized to CSS)
@yann300 yann300 merged commit b660c90 into master May 19, 2026
24 of 33 checks passed
@yann300 yann300 deleted the fix/quickdapp-review-comments branch May 19, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-review PR ready to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants