Skip to content

Fix Topbar UI Bug#7225

Merged
yann300 merged 12 commits into
masterfrom
joe-patch-046
May 27, 2026
Merged

Fix Topbar UI Bug#7225
yann300 merged 12 commits into
masterfrom
joe-patch-046

Conversation

@joeizang
Copy link
Copy Markdown
Collaborator

@joeizang joeizang commented May 18, 2026

fixes #7175

@joeizang joeizang requested a review from ryestew May 18, 2026 13:21
@joeizang joeizang self-assigned this May 18, 2026
@joeizang joeizang added the WIP label May 18, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 18, 2026 •
edited
Loading

✅ Deploy Preview for reliable-cocada-166884 ready!

Name Link
🔨 Latest commit d83d83c
🔍 Latest deploy log https://app.netlify.com/projects/reliable-cocada-166884/deploys/6a1714c2b657ab00086f8cf8
😎 Deploy Preview https://deploy-preview-7225--reliable-cocada-166884.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Aniket-Engg
Aniket-Engg reviewed May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback button is keeping only icon when we dock wallet on right but when we close right side wallet it is not bring back the text Feedback inside button

Aniket-Engg
Aniket-Engg reviewed May 21, 2026
View reviewed changes
Comment thread libs/remix-ui/top-bar/src/lib/remix-ui-topbar.tsx Outdated
try {
await renameWorkspace(currMenuName, workspaceName)
} catch (e) {
await renameWorkspace(currMenuName ?? '', workspaceName)
Copy link
Copy Markdown
Collaborator

@Aniket-Engg Aniket-Engg May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change is required?

Copy link
Copy Markdown
Collaborator

@Aniket-Engg Aniket-Engg May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeizang can you answer this?

Comment thread libs/remix-ui/top-bar/src/lib/remix-ui-topbar.tsx Outdated
const onFinishDeleteWorkspace = async (workspaceName?: string) => {
try {
await deleteWorkspace(workspaceName)
await deleteWorkspace(workspaceName ?? '')
Copy link
Copy Markdown
Collaborator

@Aniket-Engg Aniket-Engg May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this too

@joeizang joeizang requested a review from Aniket-Engg May 21, 2026 15:02
@joeizang joeizang added ready-to-review PR ready to review and removed WIP labels May 21, 2026
@Aniket-Engg
Copy link
Copy Markdown
Collaborator

Aniket-Engg commented May 25, 2026 •
edited
Loading

Feedback button is keeping only icon when we dock wallet on right but when we close right side wallet it is not bring back the text Feedback inside button

this is still happening @joeizang

@joeizang
Copy link
Copy Markdown
Collaborator Author

joeizang commented May 25, 2026

Feedback button is keeping only icon when we dock wallet on right but when we close right side wallet it is not bring back the text Feedback inside button

this is still happening @joeizang

This is because of screen resolution troubles again. I will make the limits pretty small then. I addressed this testing for screens that are 1080p @ 125% scaling. I will work on this some more today.

ryestew
ryestew approved these changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ryestew ryestew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 27, 2026 •
edited
Loading

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.

View your CI Pipeline Execution ↗ for commit d83d83c

Command Status Duration Result
nx build remix-ide --cloud --verbose ❌ Failed 2m 40s View ↗
nx lint vyper ✅ Succeeded <1s View ↗
nx lint remixd ✅ Succeeded <1s View ↗
nx lint solhint ✅ Succeeded <1s View ↗
nx lint doc-gen ✅ Succeeded <1s View ↗
nx lint remix-ui ✅ Succeeded 13s View ↗
nx lint learneth ✅ Succeeded <1s View ↗
nx lint debugger ✅ Succeeded <1s View ↗
Additional runs (25) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2026-05-27 16:42:34 UTC

@ci-pr-comment
Copy link
Copy Markdown

ci-pr-comment Bot commented May 27, 2026 •
edited
Loading

❌ E2E failures detected (workflow: web)

Last run: Wed, May 27, 2026, 04:49 PM UTC

View HTML report

Top failing tests (1/1):

  • Should login via the test pool through the real UI flow (debugger_group3.test)

Report generated by CI; artifacts are retained per CircleCI retention settings.

@yann300 yann300 merged commit eab97a2 into master May 27, 2026
8 of 10 checks passed
@yann300 yann300 deleted the joe-patch-046 branch May 27, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryestew ryestew ryestew approved these changes

@Aniket-Engg Aniket-Engg Awaiting requested review from Aniket-Engg

Assignees

@joeizang joeizang

Labels

ready-to-review PR ready to review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Layout problem when browser wallet is docked to Remix Window

4 participants

@joeizang @Aniket-Engg @ryestew @yann300