fix: avoid duplicate client HMR updates#15319
Open
wanxiankai wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13774
What changed
Why
Vite invokes the
hotUpdatehook for separate client and SSR environments. The React Router bridge also ran in the client environment and reloaded modules already present in the client graph. As a result, a single source edit evaluated the route module multiple times and could trigger unrelated updates.The bridge now only propagates changes from SSR-only modules. Client modules continue to use Vite's native HMR path, while server-only loader dependencies still walk to and reload their client parents.
The regression reproduced four total browser evaluations (initial load plus three updates) before the fix and now verifies exactly two (initial load plus one update).
Verification
pnpm buildpnpm typecheckpnpm lint(0 errors)pnpm test --no-watchman(2,629 passed, 15 skipped)pnpm test:integration:run --project=chromium vite-hmr-hdr-test.ts(6 passed)pnpm format:checkgit diff --check