feat(rsc): support CSP nonces in document rendering#15320
Open
jacob-ebey wants to merge 2 commits into
Open
Conversation
Contributor
Preview Build AvailablePreview builds have been created for this PR. You can install pnpm install "remix-run/react-router#preview/pr-15320&path:packages/react-router"And/or install other packages via: pnpm install "remix-run/react-router#preview/pr-15320&path:packages/react-router-dev"
pnpm install "remix-run/react-router#preview/pr-15320&path:packages/react-router-express"
pnpm install "remix-run/react-router#preview/pr-15320&path:packages/react-router-node"
pnpm install "remix-run/react-router#preview/pr-15320&path:packages/react-router-serve"These preview builds will be updated automatically as you push new commits. |
Contributor
✅ CLA SignedThanks for signing the Contributor License Agreement. |
Contributor
✅ Change File FoundOne or more change files found.
|
brophdawg11
approved these changes
Jul 16, 2026
| return renderHTMLToReadableStream( | ||
| <RSCStaticRouter getPayload={getPayload} nonce={options.nonce} />, | ||
| { | ||
| ...options, |
Contributor
There was a problem hiding this comment.
does options include other things not relevant for renderHTMLToReadableStream? If so, probably better iuf we just make the option explicit:
Suggested change
| ...options, | |
| nonce: options.nonce, |
| nonce={options.nonce} | ||
| />, | ||
| { | ||
| ...options, |
Contributor
There was a problem hiding this comment.
Same as below
Suggested change
| ...options, | |
| nonce: options.nonce, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.