Fix scoreboard chart and ranking issues

- Disable dataZoom slider with fewer than 2 data points (ECharts bug)
- Use notMerge on ChallengePlot setOption to match PointsOverTimeChart
- Filter zero-score teams from rankings and challenge plots
- Move time-window filtering to backend, simplify frontend ranking
- Add assignment names to chart boundary markers

Author: Nils Bars

spa-frontend/src/components/scoreboard/ChallengePlot.vue

@@ -53,7 +53,9 @@ function buildSeries() {
   const teams = (props.submissions && props.submissions[props.challengeName]) || {};
   const baseline = findBaseline();
   const mark = getMarkLineColors();
-  return Object.entries(teams).map(([team, points], index) => {
+  return Object.entries(teams).filter(([, points]) =>
+    points.some((e) => Number(e.score) > 0),
+  ).map(([team, points], index) => {
     const parsed = points
       .map((entry) => {
         const d = parseApiDate(entry.ts);
@@ -132,8 +134,12 @@ function buildOption(): EChartsOption {
   const series = buildSeries();
   const xMin = earliestX(series);
   const common = buildCommonOptions(xMin);
+  const totalPoints = series.reduce((n, s) => n + s.data.length, 0);
   return {
     ...common,
+    // ECharts renders a broken zoom slider when there is only one data
+    // point — disable it entirely in that case.
+    ...(totalPoints < 2 ? { dataZoom: [] } : {}),
     tooltip: {
       ...(common.tooltip ?? {}),
       trigger: 'item',
@@ -168,7 +174,7 @@ function buildOption(): EChartsOption {
 function render() {
   if (!root.value) return;
   if (!chart) chart = mountChart(root.value);
-  chart.chart.setOption(buildOption());
+  chart.chart.setOption(buildOption(), { notMerge: true });
 }
 
 let offTheme: (() => void) | null = null;

spa-frontend/src/components/scoreboard/PointsOverTimeChart.vue

@@ -13,10 +13,11 @@ import {
   type ManagedChart,
 } from './chartSetup';
 import type { ScoresOverTime } from '../../ranking/types';
+import type { AssignmentBoundary } from '../../ranking/util';
 
 const props = defineProps<{
   scoresOverTime: ScoresOverTime;
-  assignmentBoundaries: Date[];
+  assignmentBoundaries: AssignmentBoundary[];
 }>();
 
 const root = ref<HTMLDivElement | null>(null);
@@ -58,15 +59,15 @@ function buildSeries() {
             verticalAlign: 'middle' as const,
             color: mark.label,
             formatter: ({ dataIndex }: { dataIndex: number }) =>
-              `Assignment ${dataIndex + 1}`,
+              props.assignmentBoundaries[dataIndex]?.name ?? `Assignment ${dataIndex + 1}`,
           },
           lineStyle: {
             color: mark.line,
             type: 'dashed' as const,
             width: 1,
           },
-          data: props.assignmentBoundaries.map((time) => ({
-            xAxis: time.getTime(),
+          data: props.assignmentBoundaries.map((b) => ({
+            xAxis: b.date.getTime(),
           })),
         }
       : undefined,
@@ -95,15 +96,19 @@ function dataRange(series: Array<{ data: Array<{ value: [number, number] }> }>):
 function buildOption(): EChartsOption {
   const series = buildSeries();
   const { min: dataMin, max: dataMax } = dataRange(series);
-  const boundaries = props.assignmentBoundaries.map((d) => d.getTime());
+  const boundaries = props.assignmentBoundaries.map((b) => b.date.getTime());
   const allMins = [dataMin, ...boundaries].filter((n) => Number.isFinite(n));
   const allMaxs = [dataMax, ...boundaries].filter((n) => Number.isFinite(n));
   const xMin = allMins.length ? Math.min(...allMins) : 0;
   const xMax = allMaxs.length ? Math.max(...allMaxs) : 0;
   const pad = xMax > xMin ? (xMax - xMin) * 0.02 : 0;
   const common = buildCommonOptions(xMin - pad, xMax + pad);
+  const totalPoints = series.reduce((n, s) => n + s.data.length, 0);
   return {
     ...common,
+    // ECharts renders a broken zoom slider when there is only one data
+    // point — disable it entirely in that case.
+    ...(totalPoints < 2 ? { dataZoom: [] } : {}),
     tooltip: {
       ...(common.tooltip ?? {}),
       trigger: 'axis',
@@ -131,7 +136,7 @@ function buildOption(): EChartsOption {
 function render() {
   if (!root.value) return;
   if (!chart) chart = mountChart(root.value);
-  chart.chart.setOption(buildOption());
+  chart.chart.setOption(buildOption(), { notMerge: true });
 }
 
 let offTheme: (() => void) | null = null;

spa-frontend/src/ranking/best_sum.ts

@@ -17,23 +17,22 @@ function bestPerChallenge(
   assignments: Assignments,
   submissions: SubmissionsByChallenge,
 ): Record<string, Record<string, number>> {
-  const best: Record<string, Record<string, number>> = {};
+  const knownChallenges = new Set<string>();
   for (const challenges of Object.values(assignments || {})) {
-    for (const [name, cfg] of Object.entries(challenges || {})) {
-      const cStart = parseApiDate(cfg.start);
-      const cEnd = parseApiDate(cfg.end);
-      if (!cStart || !cEnd) continue;
-      const teams = (submissions && submissions[name]) || {};
-      if (!best[name]) best[name] = {};
-      for (const team of Object.keys(teams)) {
-        for (const entry of teams[team] || []) {
-          const ts = parseApiDate(entry.ts);
-          if (!ts || ts < cStart || ts > cEnd) continue;
-          const score = Number(entry.score);
-          if (!Number.isFinite(score)) continue;
-          if (!(team in best[name]) || score > best[name][team]) {
-            best[name][team] = score;
-          }
+    for (const name of Object.keys(challenges || {})) {
+      knownChallenges.add(name);
+    }
+  }
+  const best: Record<string, Record<string, number>> = {};
+  for (const [name, teams] of Object.entries(submissions || {})) {
+    if (!knownChallenges.has(name)) continue;
+    if (!best[name]) best[name] = {};
+    for (const team of Object.keys(teams)) {
+      for (const entry of teams[team] || []) {
+        const score = Number(entry.score);
+        if (!Number.isFinite(score)) continue;
+        if (!(team in best[name]) || score > best[name][team]) {
+          best[name][team] = score;
         }
       }
     }
@@ -52,7 +51,7 @@ export function getRanking(
       totals[team] = (totals[team] || 0) + score;
     }
   }
-  return Object.entries(totals).sort((a, b) => b[1] - a[1]);
+  return Object.entries(totals).filter(([, score]) => score > 0).sort((a, b) => b[1] - a[1]);
 }
 
 export function computeChartScoresOverTime(
@@ -74,20 +73,21 @@ export function computeChartScoresOverTime(
   }
 
   const events: Ev[] = [];
+  const knownChallenges = new Set<string>();
   for (const challenges of Object.values(assignments || {})) {
-    for (const [name, cfg] of Object.entries(challenges || {})) {
-      const cStart = parseApiDate(cfg.start);
-      const cEnd = parseApiDate(cfg.end);
-      if (!cStart || !cEnd) continue;
-      const teams = (submissions && submissions[name]) || {};
-      for (const team of Object.keys(teams)) {
-        for (const entry of teams[team] || []) {
-          const ts = parseApiDate(entry.ts);
-          if (!ts || ts < cStart || ts > cEnd) continue;
-          const score = Number(entry.score);
-          if (!Number.isFinite(score)) continue;
-          events.push({ ts, team, challenge: name, score });
-        }
+    for (const name of Object.keys(challenges || {})) {
+      knownChallenges.add(name);
+    }
+  }
+  for (const [name, teams] of Object.entries(submissions || {})) {
+    if (!knownChallenges.has(name)) continue;
+    for (const team of Object.keys(teams)) {
+      for (const entry of teams[team] || []) {
+        const ts = parseApiDate(entry.ts);
+        if (!ts) continue;
+        const score = Number(entry.score);
+        if (!Number.isFinite(score)) continue;
+        events.push({ ts, team, challenge: name, score });
       }
     }
   }
@@ -105,8 +105,8 @@ export function computeChartScoresOverTime(
     if (ev.score > prev) {
       totals[ev.team] += ev.score - prev;
       bestPer[ev.team][ev.challenge] = ev.score;
+      out[ev.team].push({ time: ev.ts.getTime(), score: totals[ev.team] });
     }
-    out[ev.team].push({ time: ev.ts.getTime(), score: totals[ev.team] });
   }
 
   for (const team of teamSet) {

spa-frontend/src/ranking/util.ts

@@ -69,16 +69,11 @@ export function getBadges(
 ): Badges {
   const out: Badges = {};
   for (const challenges of Object.values(assignments || {})) {
-    for (const [challenge, cfg] of Object.entries(challenges || {})) {
-      const cStart = parseApiDate(cfg.start);
-      const cEnd = parseApiDate(cfg.end);
-      if (!cStart || !cEnd) continue;
+    for (const [challenge] of Object.entries(challenges || {})) {
       const teams = (submissions && submissions[challenge]) || {};
       for (const team of Object.keys(teams)) {
         let earned = false;
         for (const entry of teams[team] || []) {
-          const ts = parseApiDate(entry.ts);
-          if (!ts || ts < cStart || ts > cEnd) continue;
           if (Number(entry.score) > 0) {
             earned = true;
             break;
@@ -138,18 +133,20 @@ export function getActiveAssignmentName(
   return activeName ?? upcomingName;
 }
 
+export type AssignmentBoundary = { name: string; date: Date };
+
 export function computeAssignmentStartTimes(
   assignments: Assignments,
-): Date[] {
-  const times: Date[] = [];
-  for (const challenges of Object.values(assignments || {})) {
+): AssignmentBoundary[] {
+  const boundaries: AssignmentBoundary[] = [];
+  for (const [name, challenges] of Object.entries(assignments || {})) {
     let earliest: Date | null = null;
     for (const ch of Object.values(challenges || {}) as ChallengeCfg[]) {
       const s = parseApiDate(ch.start);
       if (s && (!earliest || s < earliest)) earliest = s;
     }
-    if (earliest) times.push(earliest);
+    if (earliest) boundaries.push({ name, date: earliest });
   }
-  times.sort((a, b) => a.getTime() - b.getTime());
-  return times;
+  boundaries.sort((a, b) => a.date.getTime() - b.date.getTime());
+  return boundaries;
 }