Extract WorkingDir from git.Client into workdir package

The working directory is not git-specific — it's the directory where
the entire application operates. Move it to a shared workdir.Path
variable so all packages (git, test, mob) use the same source of truth.

https://claude.ai/code/session_0162Mf6jkLfhrQP3PAWWyhgr

Author: claude

git/git.go

@@ -10,17 +10,17 @@ import (
 	config "github.com/remotemobprogramming/mob/v5/configuration"
 	"github.com/remotemobprogramming/mob/v5/exit"
 	"github.com/remotemobprogramming/mob/v5/say"
+	"github.com/remotemobprogramming/mob/v5/workdir"
 )
 
 type Client struct {
-	WorkingDir              string
 	PassthroughStderrStdout bool
 }
 
 func (g *Client) runCommandSilent(name string, args ...string) (string, string, error) {
 	command := exec.Command(name, args...)
-	if len(g.WorkingDir) > 0 {
-		command.Dir = g.WorkingDir
+	if len(workdir.Path) > 0 {
+		command.Dir = workdir.Path
 	}
 	commandString := strings.Join(command.Args, " ")
 	say.Debug("Running command <" + commandString + "> in silent mode, capturing combined output")
@@ -32,8 +32,8 @@ func (g *Client) runCommandSilent(name string, args ...string) (string, string,
 
 func (g *Client) runCommand(name string, args ...string) (string, string, error) {
 	command := exec.Command(name, args...)
-	if len(g.WorkingDir) > 0 {
-		command.Dir = g.WorkingDir
+	if len(workdir.Path) > 0 {
+		command.Dir = workdir.Path
 	}
 	commandString := strings.Join(command.Args, " ")
 	say.Debug("Running command <" + commandString + "> passing output through")

mob.go

@@ -21,6 +21,7 @@ import (
 	"github.com/remotemobprogramming/mob/v5/help"
 	"github.com/remotemobprogramming/mob/v5/open"
 	"github.com/remotemobprogramming/mob/v5/say"
+	"github.com/remotemobprogramming/mob/v5/workdir"
 )
 
 const (
@@ -252,7 +253,7 @@ func run(osArgs []string) {
 	say.Debug("command '" + command + "'")
 	say.Debug("parameters '" + strings.Join(parameters, " ") + "'")
 	say.Debug("version " + versionNumber)
-	say.Debug("workingDir '" + gitClient.WorkingDir + "'")
+	say.Debug("workingDir '" + workdir.Path + "'")
 
 	// workaround until we have a better design
 	if configuration.GitHooksEnabled {
@@ -877,10 +878,10 @@ func getPathOfLastModifiedFile() string {
 // uses git status --porcelain. To work properly files have to be staged.
 func getModifiedFiles(rootDir string) []string {
 	say.Debug("Find modified files")
-	oldWorkingDir := gitClient.WorkingDir
-	gitClient.WorkingDir = rootDir
+	oldWorkingDir := workdir.Path
+	workdir.Path = rootDir
 	gitstatus := silentgit("status", "--porcelain")
-	gitClient.WorkingDir = oldWorkingDir
+	workdir.Path = oldWorkingDir
 	lines := strings.Split(gitstatus, "\n")
 	files := []string{}
 	for _, line := range lines {
@@ -1114,8 +1115,8 @@ func isGit() bool {
 
 func startCommand(name string, args ...string) (string, error) {
 	command := exec.Command(name, args...)
-	if len(gitClient.WorkingDir) > 0 {
-		command.Dir = gitClient.WorkingDir
+	if len(workdir.Path) > 0 {
+		command.Dir = workdir.Path
 	}
 	commandString := strings.Join(command.Args, " ")
 	say.Debug("Starting command " + commandString)

mob_test.go

@@ -8,6 +8,7 @@ import (
 	"github.com/remotemobprogramming/mob/v5/exit"
 	"github.com/remotemobprogramming/mob/v5/open"
 	"github.com/remotemobprogramming/mob/v5/say"
+	"github.com/remotemobprogramming/mob/v5/workdir"
 	"path/filepath"
 	"reflect"
 	"runtime"
@@ -209,7 +210,7 @@ func TestStart(t *testing.T) {
 
 func TestStartDespiteGitHook(t *testing.T) {
 	_, configuration := setup(t)
-	createExecutableFileInPath(t, gitClient.WorkingDir+"/.git/hooks", "pre-commit", "#!/bin/sh\necho 'boo'\nexit 1\n")
+	createExecutableFileInPath(t, workdir.Path+"/.git/hooks", "pre-commit", "#!/bin/sh\necho 'boo'\nexit 1\n")
 
 	start(configuration)
 
@@ -854,7 +855,7 @@ func TestStartNextStay_WriteLastModifiedFileInCommit_WhenFileIsModifiedAndWorkin
 	start(configuration)
 	createDirectory(t, "dir")
 	createFile(t, "file1.txt", "contentIrrelevantButModified")
-	setWorkingDir(gitClient.WorkingDir + "/dir")
+	setWorkingDir(workdir.Path + "/dir")
 	next(configuration)
 
 	assertOnBranch(t, "mob-session")
@@ -884,7 +885,7 @@ func TestStartNextStay_DoNotWriteLastModifiedFileInCommit_WhenFileIsDeleted(t *t
 	next(configuration)
 
 	start(configuration)
-	removeFile(t, filepath.Join(gitClient.WorkingDir, "file1.txt"))
+	removeFile(t, filepath.Join(workdir.Path, "file1.txt"))
 	next(configuration)
 
 	assertOnBranch(t, "mob-session")
@@ -901,7 +902,7 @@ func TestStartNextStay_DoNotWriteLastModifiedFileInCommit_WhenFileIsMoved(t *tes
 
 	start(configuration)
 	createDirectory(t, "dir")
-	moveFile(t, filepath.Join(gitClient.WorkingDir, "file1.txt"), filepath.Join(gitClient.WorkingDir, "dir", "file1.txt"))
+	moveFile(t, filepath.Join(workdir.Path, "file1.txt"), filepath.Join(workdir.Path, "dir", "file1.txt"))
 	next(configuration)
 
 	assertOnBranch(t, "mob-session")
@@ -2090,7 +2091,7 @@ func resetExit() {
 }
 
 func createTestbed(t *testing.T, configuration config.Configuration) {
-	gitClient.WorkingDir = ""
+	workdir.Path = ""
 
 	tempDir = t.TempDir()
 
@@ -2121,7 +2122,7 @@ func createTestbedIn(t *testing.T, temporaryDirectory string) {
 	cloneRepository(localDirectory, remoteDirectory)
 
 	say.Debug("Populate, initial import and push")
-	gitClient.WorkingDir = localDirectory
+	workdir.Path = localDirectory
 	createFile(t, "test.txt", "test")
 	createDirectory(t, "subdir")
 	createFileInPath(t, localDirectory+"/subdir", "subdir.txt", "subdir")
@@ -2153,7 +2154,7 @@ func createTestbedIn(t *testing.T, temporaryDirectory string) {
 }
 
 func setWorkingDir(dir string) {
-	gitClient.WorkingDir = dir
+	workdir.Path = dir
 	say.Say("\n===== cd " + dir)
 }
 
@@ -2181,7 +2182,7 @@ func assertCommitsOnBranch(t *testing.T, commits int, branchName string) {
 	result := silentgit("rev-list", "--count", branchName)
 	number, _ := strconv.Atoi(result)
 	if number != commits {
-		failWithFailure(t, strconv.Itoa(commits)+" commits in "+gitClient.WorkingDir, strconv.Itoa(number)+" commits in "+gitClient.WorkingDir)
+		failWithFailure(t, strconv.Itoa(commits)+" commits in "+workdir.Path, strconv.Itoa(number)+" commits in "+workdir.Path)
 	}
 }
 
@@ -2200,7 +2201,7 @@ func assertCommitLogNotContainsMessage(t *testing.T, branchName string, commitMe
 }
 
 func assertFileExist(t *testing.T, filename string) {
-	path := gitClient.WorkingDir + "/" + filename
+	path := workdir.Path + "/" + filename
 	if strings.Index(filename, "/") == 0 {
 		path = filename
 	}
@@ -2216,7 +2217,7 @@ func createFileAndCommitIt(t *testing.T, filename string, content string, commit
 }
 
 func createFile(t *testing.T, filename string, content string) (pathToFile string) {
-	return createFileInPath(t, gitClient.WorkingDir, filename, content)
+	return createFileInPath(t, workdir.Path, filename, content)
 }
 
 func createFileInPath(t *testing.T, path, filename, content string) (pathToFile string) {
@@ -2242,7 +2243,7 @@ func createExecutableFileInPath(t *testing.T, path, filename, content string) (p
 }
 
 func createDirectory(t *testing.T, directory string) (pathToDirectory string) {
-	return ensureDirectoryExists(t, gitClient.WorkingDir+"/"+directory)
+	return ensureDirectoryExists(t, workdir.Path+"/"+directory)
 }
 
 func ensureDirectoryExists(t *testing.T, path string) (pathToDirectory string) {
@@ -2378,7 +2379,7 @@ func createRemoteRepository(path string) {
 		say.Error(err.Error())
 		return
 	}
-	gitClient.WorkingDir = path
+	workdir.Path = path
 	say.Debug("before git init")
 	git("--bare", "init")
 	say.Debug("before symbolic-ref")
@@ -2396,7 +2397,7 @@ func cloneRepository(path, remoteDirectory string) {
 		say.Error(err.Error())
 		return
 	}
-	gitClient.WorkingDir = path
+	workdir.Path = path
 	name := basename(path)
 	git("clone", "--origin", "origin", "file://"+remoteDirectory, ".")
 	git("config", "--local", "user.name", name)

test/test.go

@@ -3,6 +3,7 @@ package test
 import (
 	"fmt"
 	"github.com/remotemobprogramming/mob/v5/say"
+	"github.com/remotemobprogramming/mob/v5/workdir"
 	"os"
 	"path/filepath"
 	"reflect"
@@ -13,10 +14,6 @@ import (
 	"time"
 )
 
-var (
-	workingDir string
-)
-
 const (
 	AWAIT_DEFAULT_POLL_INTERVAL = 100 * time.Millisecond
 	AWAIT_DEFAULT_AT_MOST       = 2 * time.Second
@@ -50,7 +47,7 @@ func failWithFailureMessage(t *testing.T, message string) {
 
 func CreateFile(t *testing.T, filename string, content string) (pathToFile string) {
 	contentAsBytes := []byte(content)
-	pathToFile = workingDir + "/" + filename
+	pathToFile = workdir.Path + "/" + filename
 	err := os.WriteFile(pathToFile, contentAsBytes, 0644)
 	if err != nil {
 		failWithFailure(t, "creating file "+filename+" with content "+content, "error")
@@ -59,7 +56,7 @@ func CreateFile(t *testing.T, filename string, content string) (pathToFile strin
 }
 
 func SetWorkingDir(dir string) {
-	workingDir = dir
+	workdir.Path = dir
 	say.Say("\n===== cd " + dir)
 }
 

workdir/workdir.go

@@ -0,0 +1,3 @@
+package workdir
+
+var Path string