Replace lodash with es-toolkit to remove deprecated dependency and CommonJS optimization bailouts #254
Open
denatys wants to merge 7 commits into
Open
Replace lodash with es-toolkit to remove deprecated dependency and CommonJS optimization bailouts #254denatys wants to merge 7 commits into
denatys wants to merge 7 commits into
Conversation
…mmonJS optimization bailouts
…mmonJS optimization bailouts
…mmonJS optimization bailouts
…mmonJS optimization bailouts
…mmonJS optimization bailouts
Contributor
Author
|
@sandrina-p @danielcardoso5 please review |
Collaborator
|
Hi @denatys, thanks for your MR! We'll review this later in the week, max early next one. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #253
Note
Medium Risk
Swaps a foundational utility dependency (
lodash) fores-toolkit/compatacross schema modification and v0 form logic, which could introduce subtle behavioral differences inmerge*,get/set, and array handling. Changes are broad but mostly mechanical and covered by updated tests/lockfiles.Overview
Replaces
lodashwithes-toolkit/compatthroughout the codebase (both v2src/modify-schema.tsand the v0 implementation), updating all imports for common helpers likemerge,mergeWith,get/set,difference, etc., and removinglodash/@types/lodashfrom manifests.Dependency plumbing and tests were adjusted: lockfiles now include
es-toolkit, v0package.json/package-lock.jsonare updated, and a couple test fixtures were tweaked (e.g.,merge({}, …)call sites and a minor expected-schema shape change inmodify.test.js) to align with the new utility behavior.Reviewed by Cursor Bugbot for commit b8b5b8f. Bugbot is set up for automated code reviews on this repo. Configure here.