fix: modify() preserve unknown top-level schema keys when using pick#264
Merged
sandrina-p merged 2 commits intoJul 10, 2026
Merged
Conversation
pickFields() only copied properties/x-jsf-order/required/allOf/x-jsf-logic, silently dropping anything else (type, x-rmt-meta, additionalProperties...). Add a default case so unrecognized keys pass through, matching v0 behavior.
nitin-remote
approved these changes
Jul 10, 2026
nitin-remote
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
This bug happens in v1, but not in v0.
modify()used withpicksilently drops any top-level schema key it doesn't explicitly know about (type,x-rmt-meta,additionalProperties,$schema, etc). Onlyproperties,x-jsf-order,required,allOf,x-jsf-logicsurvived.Repro:
Fix
Added the missing
defaultcase so unrecognized top-level keys pass through unchanged, matching v0.