chore(button) - remove react-slot (#781)

* remove label && slot

* remove react-label dependency

* remove dependency

* format

* adapt plan

* chore(button) - remove react-slog

* updates

* update plan

* edit plan

* format

Author: gabrielseco

example/package-lock.json

@@ -95,7 +95,6 @@
     "@radix-ui/react-radio-group": "^1.3.8",
     "@radix-ui/react-scroll-area": "^1.2.10",
     "@radix-ui/react-select": "^2.2.6",
-    "@radix-ui/react-slot": "^1.2.4",
     "@radix-ui/react-tabs": "^1.1.13",
     "@remoteoss/remote-json-schema-form-kit": "github:remoteoss/remote-json-schema-form-kit#v0.0.5",
     "@tailwindcss/cli": "^4.1.17",

package-lock.json

@@ -22,11 +22,8 @@ Decouple all Radix UI (and other visual) dependencies from the library core, mak
 
 ### Visual components embedded in flows/shared (must be made overridable or moved)
 
-- `EstimationResults` — uses `Card`, `Accordion`, `BasicTooltip`, `ActionsDropdown`
-- `SummaryResults` — uses `Card`, `Accordion`
-- `Termination/PaidTimeOff` — uses `Button`
-- `ContractorOnboarding/ContractPreviewStatement` — uses `Alert`
-- `ActionsDropdown` — uses `Button` from `ui/button`
+- `EstimationResults` — uses `Accordion`
+- `SummaryResults` — uses `Accordion`
 
 ---
 

package.json

@@ -1,5 +1,4 @@
 import * as React from 'react';
-import { Slot } from '@radix-ui/react-slot';
 import { cva, type VariantProps } from 'class-variance-authority';
 
 import { cn } from '@/src/lib/utils';
@@ -28,14 +27,10 @@ const badgeVariants = cva(
 function Badge({
   className,
   variant,
-  asChild = false,
   ...props
-}: React.ComponentProps<'span'> &
-  VariantProps<typeof badgeVariants> & { asChild?: boolean }) {
-  const Comp = asChild ? Slot : 'span';
-
+}: React.ComponentProps<'span'> & VariantProps<typeof badgeVariants>) {
   return (
-    <Comp
+    <span
       data-slot='badge'
       className={cn(badgeVariants({ variant }), className)}
       {...props}

plans/headless-library.md

@@ -1,4 +1,3 @@
-import { Slot } from '@radix-ui/react-slot';
 import { cva, type VariantProps } from 'class-variance-authority';
 import * as React from 'react';
 
@@ -40,16 +39,10 @@ function Button({
   className,
   variant,
   size,
-  asChild = false,
   ...props
-}: React.ComponentProps<'button'> &
-  VariantProps<typeof buttonVariants> & {
-    asChild?: boolean;
-  }) {
-  const Comp = asChild ? Slot : 'button';
-
+}: React.ComponentProps<'button'> & VariantProps<typeof buttonVariants>) {
   return (
-    <Comp
+    <button
       data-slot='button'
       className={cn(
         buttonVariants({ variant, size, className }),