Skip to content

Pre onboarding requirements#1064

Open
gabrielseco wants to merge 41 commits into
mainfrom
pre-onboarding-requirements
Open

Pre onboarding requirements#1064
gabrielseco wants to merge 41 commits into
mainfrom
pre-onboarding-requirements

Conversation

@gabrielseco
Copy link
Copy Markdown
Collaborator

@gabrielseco gabrielseco commented May 27, 2026

Note

Medium Risk
Changes onboarding completion rules (invite gating) and adds legally sensitive document signing; well covered by tests but affects a critical hire path.

Overview
Adds pre-onboarding document requirements to the employee onboarding review step: list requirements per employment, optionally acknowledge country hiring constraints, find-or-create a document, preview the PDF in a full-screen viewer, and sign with a typed name.

The flow exposes a new PreOnboardingRequirements render-prop component (and PreOnboardingRequirementsBag type) wired through OnboardingFlow, with React Query hooks against the new onboarding pre-onboarding document APIs. Invite is blocked until every requirement has status finished (and stays disabled while requirements are still loading).

The example ReviewOnboardingStep implements the UX (cards, blocked-state tooltip, modals). The OpenAPI client is regenerated with the new endpoints and related types; v2 offboarding, employee current, and leave-policy summary endpoints are also included in the client export. Tests cover document create/sign, blocked requirements, and invite-button gating.

Reviewed by Cursor Bugbot for commit 171314d. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 215.31 kB 212.75 kB +2.56 kB (+1.2%) 🔴
Total (raw) 585.22 kB 576.92 kB +8.3 kB (+1.4%) 🔴
CSS (gzip) 20.89 kB 20.86 kB +25 B (+0.1%) 🔴
CSS (raw) 109.09 kB 108.83 kB +262 B (+0.2%) 🔴

Size Limits

  • ✅ Total gzipped: 215.31 kB / 250 kB (86.1%)
  • ✅ Total raw: 585.22 kB / 600 kB (97.5%)
  • ✅ CSS gzipped: 20.89 kB / 25 kB (83.5%)

Largest Files (Top 5)

  1. chunk-UGPYPGVV.js - 14 kB (0 B (0%))
  2. styles.css - 10.44 kB (+13 B (+0.1%))
  3. index.css - 10.44 kB (+12 B (+0.1%))
  4. chunk-3X7AW77R.js - 6.36 kB (new)
  5. index.js - 6.14 kB (+14 B (+0.2%))
View All Files (317 total)
File Size (gzip) Change
chunk-UGPYPGVV.js 14 kB 0 B (0%)
styles.css 10.44 kB +13 B (+0.1%)
index.css 10.44 kB +12 B (+0.1%)
chunk-3X7AW77R.js 6.36 kB new
index.js 6.14 kB +14 B (+0.2%)
chunk-VHUMGFM6.js 6 kB new
chunk-EFL7QFFN.js 5.29 kB 0 B (0%)
chunk-GBUGQDKS.js 4.76 kB new
chunk-ONVDK2TC.js 4.45 kB new
chunk-UGPSQFC5.js 3.89 kB new

✅ Bundle size check passed

Comment thread src/tests/handlers.ts
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-525zmfpfn-remotecom.vercel.app
Latest Commit:171314d

Deployed with vercel-action

Comment thread src/flows/Onboarding/hooks.tsx Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

📊 Coverage Report

⚠️ Coverage decreased

Metric Current Previous Change Status
Lines 89.98% 90.08% -0.10% 🔴
Statements 89.65% 89.73% -0.08% 🔴
Functions 87.12% 87.67% -0.55% 🔴
Branches 80.20% 80.22% -0.02% 🔴

Detailed Breakdown

Lines Coverage
  • Covered: 3790 / 4212
  • Coverage: 89.98%
  • Change: -0.10% (67 lines)
Statements Coverage
  • Covered: 3853 / 4298
  • Coverage: 89.65%
  • Change: -0.08% (70 statements)
Functions Coverage
  • Covered: 1028 / 1180
  • Coverage: 87.12%
  • Change: -0.55% (18 functions)
Branches Coverage
  • Covered: 2354 / 2935
  • Coverage: 80.20%
  • Change: -0.02% (22 branches)

✅ Coverage check passed

Comment thread src/flows/Onboarding/components/PreOnboardingRequirements.tsx
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1b8f15f. Configure here.

Comment thread example/src/ReviewOnboardingStep.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant