Pre onboarding requirements#1064
Open
gabrielseco wants to merge 41 commits into
Open
Conversation
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (317 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report
|
| Metric | Current | Previous | Change | Status |
|---|---|---|---|---|
| Lines | 89.98% | 90.08% | -0.10% | 🔴 |
| Statements | 89.65% | 89.73% | -0.08% | 🔴 |
| Functions | 87.12% | 87.67% | -0.55% | 🔴 |
| Branches | 80.20% | 80.22% | -0.02% | 🔴 |
Detailed Breakdown
Lines Coverage
- Covered: 3790 / 4212
- Coverage: 89.98%
- Change: -0.10% (67 lines)
Statements Coverage
- Covered: 3853 / 4298
- Coverage: 89.65%
- Change: -0.08% (70 statements)
Functions Coverage
- Covered: 1028 / 1180
- Coverage: 87.12%
- Change: -0.55% (18 functions)
Branches Coverage
- Covered: 2354 / 2935
- Coverage: 80.20%
- Change: -0.02% (22 branches)
✅ Coverage check passed
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1b8f15f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes onboarding completion rules (invite gating) and adds legally sensitive document signing; well covered by tests but affects a critical hire path.
Overview
Adds pre-onboarding document requirements to the employee onboarding review step: list requirements per employment, optionally acknowledge country hiring constraints, find-or-create a document, preview the PDF in a full-screen viewer, and sign with a typed name.
The flow exposes a new
PreOnboardingRequirementsrender-prop component (andPreOnboardingRequirementsBagtype) wired throughOnboardingFlow, with React Query hooks against the new onboarding pre-onboarding document APIs. Invite is blocked until every requirement has statusfinished(and stays disabled while requirements are still loading).The example
ReviewOnboardingStepimplements the UX (cards, blocked-state tooltip, modals). The OpenAPI client is regenerated with the new endpoints and related types; v2 offboarding, employee current, and leave-policy summary endpoints are also included in the client export. Tests cover document create/sign, blocked requirements, and invite-button gating.Reviewed by Cursor Bugbot for commit 171314d. Bugbot is set up for automated code reviews on this repo. Configure here.