@remotion/studio-server: Support interpolateColors keyframes#7703
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — adds interpolateColors() support to the studio-server keyframe detection and codemod system, enabling visual mode editing of color keyframes.
- Generalize keyframe detection —
getInterpolateExpression/getInterpolateKeyframesrenamed togetInterpolation*and extended to match bothinterpolateandinterpolateColorscalls - Choose callee on static-to-keyframe conversion —
getInterpolationCalleeForValuesselectsinterpolateColorswhen both values are strings,interpolateotherwise - Preserve original callee — existing
interpolateColorscalls keep their callee when adding/removing keyframes - Add test coverage — tests for detecting
interpolateColorskeyframes, adding keyframes to existing color interpolations, and converting static string values to color interpolations - Add example composition —
<Solid>withinterpolateColorsinKeyframedPropsTest.tsx
Big Pickle (free) (credentials for Anthropic not configured) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #7700
Summary
interpolateColors()<Solid>case to the keyframed props example composition.interpolateColors()calls as keyframed computed props for visual mode/timeline status.interpolateColors()and emit it when adding string color keyframes.Testing
bun test packages/studio-server/src/test/update-keyframes.test.ts packages/studio-server/src/test/compute-sequence-props-status.test.tsbun run buildbun run formattingbun run stylecheck(blocked by known@remotion/lambda-goGo 1.22.2 vs required Go >= 1.23.0 environment issue)bunx turbo run lint formatting --filter='@remotion/studio-server' --filter='@remotion/example' --no-update-notifierbunx remotion still keyframed-props-test --frame=50 --props src/my-props.json --gl=swangle --output ../../out/keyframed-props-test-frame-50.pngArtifact
Rendered keyframed interpolateColors Solid
To show artifacts inline, enable in settings.