Skip to content

@remotion/studio: Prevent TimeValue from unselecting item#7837

Merged
JonnyBurger merged 3 commits into
mainfrom
jonnyburger/timevalue-selection
May 30, 2026
Merged

@remotion/studio: Prevent TimeValue from unselecting item#7837
JonnyBurger merged 3 commits into
mainfrom
jonnyburger/timevalue-selection

Conversation

@JonnyBurger
Copy link
Copy Markdown
Member

Fixes #7835.

  • Stops pointerdown propagation from the Studio TimeValue control so clicking it does not trigger selection clearing.
  • Keeps the behavior scoped to TimeValue instead of changing the reusable InputDragger globally.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment May 30, 2026 9:08am
remotion Ready Ready Preview, Comment May 30, 2026 9:08am

Request Review

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — A targeted fix preventing clicks on the Studio TimeValue control from inadvertently clearing the timeline selection.

  • Adds onPointerDown handler with e.stopPropagation() to TimeValue.tsx — stops the pointerdown event from bubbling up to TimelineClearSelectionArea, which treats any bubbled event as a click on empty space.
  • Keeps the fix scoped to TimeValue — avoids changing the reusable InputDragger component, following the pattern already used by ContextMenu.tsx for similar deselection-guard behavior.

Pullfrog  | View workflow run | Using Kimi K2𝕏

Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — A targeted fix preventing clicks on the Studio TimeValue control from inadvertently clearing the timeline selection.

  • Adds onPointerDown handler with e.stopPropagation() to TimeValue.tsx — stops the pointerdown event from bubbling up to TimelineClearSelectionArea, which treats any bubbled event as a click on empty space.
  • Keeps the fix scoped to TimeValue — avoids changing the reusable InputDragger component, following the pattern already used by ContextMenu.tsx for similar deselection-guard behavior.

Pullfrog  | View workflow run | Using Kimi K2𝕏

Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes — A targeted fix preventing clicks on the Studio TimeValue control from inadvertently clearing the timeline selection.

  • Adds onPointerDown handler with e.stopPropagation() to TimeValue.tsx — stops the pointerdown event from bubbling up to TimelineClearSelectionArea, which treats any bubbled event as a click on empty space.
  • Keeps the fix scoped to TimeValue — avoids changing the reusable InputDragger component, following the pattern already used by ContextMenu.tsx for similar deselection-guard behavior.

Pullfrog  | View workflow run | Using Kimi K2𝕏

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@JonnyBurger JonnyBurger merged commit 4ae78a4 into main May 30, 2026
18 checks passed
@JonnyBurger JonnyBurger deleted the jonnyburger/timevalue-selection branch May 30, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking TimeValue should not unselect item

1 participant