Unify fake constructor input conventions to value-in (#452)

Gets all resource constructor / factory methods on the same pattern: value-in, pointer-out.

This is a common approach in go:

- Value-in stops the constructor from mutating the caller's struct in place
- Pointer-out allows callers to mutate the constructed objects as a way to manipulate the server's state mid-test. (The pointers are also stored in the server's slices which represent database state). This is important for simulating test scenarios.

Stacked on #450. Sneaking one additional PR into this pg resume/suspend stack to clarify usage of factories.

GitOrigin-RevId: 664d60cc443a6bdb8d0add062c62184bb480a97f

Author: davidharting

cmd/kv_test.go

@@ -17,7 +17,7 @@ var ACTIVE_WORKSPACE_ID = testids.WorkspaceID("active")
 // seedKV adds a KV instance owned by the active workspace, with a random
 // valid ID and the given name. Returns the seeded detail for assertions.
 func seedKV(server *renderapi.Server, name string) *client.KeyValueDetail {
-	kv := renderapi.NewKV(&client.KeyValueDetail{
+	kv := renderapi.NewKV(client.KeyValueDetail{
 		Name:  name,
 		Owner: client.Owner{Id: ACTIVE_WORKSPACE_ID},
 	})
@@ -27,7 +27,7 @@ func seedKV(server *renderapi.Server, name string) *client.KeyValueDetail {
 
 // seedKVInEnv adds a KV instance scoped to a specific environment.
 func seedKVInEnv(server *renderapi.Server, name, envID string) *client.KeyValueDetail {
-	kv := renderapi.NewKV(&client.KeyValueDetail{
+	kv := renderapi.NewKV(client.KeyValueDetail{
 		Name:          name,
 		Owner:         client.Owner{Id: ACTIVE_WORKSPACE_ID},
 		EnvironmentId: &envID,

cmd/pg_test.go

@@ -49,15 +49,15 @@ func executePGCommand(t *testing.T, server *renderapi.Server, args ...string) (C
 
 // seedPG adds a new Postgres database to the seeded active workspace.
 func seedPG(server *renderapi.Server, name string) *client.PostgresDetail {
-	return server.Postgres.Add(renderapi.NewPostgres(&client.PostgresDetail{
+	return server.Postgres.Add(renderapi.NewPostgres(client.PostgresDetail{
 		Name:  name,
 		Owner: client.Owner{Id: pgActiveWorkspaceID},
 	}))
 }
 
 // seedPGInEnv adds a new Postgres database to the specified environment inside the active workspace.
 func seedPGInEnv(server *renderapi.Server, name string, envID string) *client.PostgresDetail {
-	return server.Postgres.Add(renderapi.NewPostgres(&client.PostgresDetail{
+	return server.Postgres.Add(renderapi.NewPostgres(client.PostgresDetail{
 		Name:          name,
 		Owner:         client.Owner{Id: pgActiveWorkspaceID},
 		EnvironmentId: pointers.From(envID),

internal/fakes/renderapi/server.go

@@ -158,10 +158,7 @@ func NewEnvironment(e client.Environment) *client.Environment {
 }
 
 // NewKV returns a KeyValueDetail with sensible defaults for any zero-value fields.
-func NewKV(kv *client.KeyValueDetail) *client.KeyValueDetail {
-	if kv == nil {
-		kv = &client.KeyValueDetail{}
-	}
+func NewKV(kv client.KeyValueDetail) *client.KeyValueDetail {
 	if kv.Id == "" {
 		kv.Id = testids.RandomKeyValueID()
 	}
@@ -186,15 +183,12 @@ func NewKV(kv *client.KeyValueDetail) *client.KeyValueDetail {
 			kv.UpdatedAt = now
 		}
 	}
-	return kv
+	return &kv
 }
 
 // NewPostgres returns a PostgresDetail with sensible defaults for any
 // zero-value fields.
-func NewPostgres(pg *client.PostgresDetail) *client.PostgresDetail {
-	if pg == nil {
-		pg = &client.PostgresDetail{}
-	}
+func NewPostgres(pg client.PostgresDetail) *client.PostgresDetail {
 	if pg.Id == "" {
 		pg.Id = testids.RandomPostgresID()
 	}
@@ -235,7 +229,7 @@ func NewPostgres(pg *client.PostgresDetail) *client.PostgresDetail {
 	if pg.UpdatedAt.IsZero() {
 		pg.UpdatedAt = now
 	}
-	return pg
+	return &pg
 }
 
 func postgresListItem(pg *client.PostgresDetail) client.Postgres {

pkg/postgres/service_test.go

@@ -58,7 +58,7 @@ func newHarness(t *testing.T) testHarness {
 
 // addPostgres creates a Postgres that is owned by the seeded Active Workspace directly (no environment)
 func (h testHarness) addPostgres(name string) *client.PostgresDetail {
-	return h.server.Postgres.Add(renderapi.NewPostgres(&client.PostgresDetail{
+	return h.server.Postgres.Add(renderapi.NewPostgres(client.PostgresDetail{
 		Name:  name,
 		Owner: client.Owner{Id: h.workspaceID},
 	}))
@@ -77,7 +77,7 @@ func (h testHarness) addPostgresInWorkspaceEnvironment(name string, workspaceID
 	project := h.requireProject(env.ProjectId)
 	require.Equal(h.t, workspaceID, project.Owner.Id, "test setup: environment %q belongs to project %q in workspace %q, not workspace %q", environmentID, project.Id, project.Owner.Id, workspaceID)
 
-	return h.server.Postgres.Add(renderapi.NewPostgres(&client.PostgresDetail{
+	return h.server.Postgres.Add(renderapi.NewPostgres(client.PostgresDetail{
 		Name:          name,
 		Owner:         client.Owner{Id: workspaceID},
 		EnvironmentId: pointers.From(environmentID),