Skip to content

Commit 1bbdc9a

Browse files
Use canonical Postgres and Key Value command names (#507)
Make `postgres` and `keyvalues` default command names. Keep and advertise the `pg` and `kv`, but use the long, plural forms as the deafults to match our command style. GROW 2581 GitOrigin-RevId: 6a862c201936b09c1d711c38bcafea3e8135dc04
1 parent e4705ce commit 1bbdc9a

3 files changed

Lines changed: 10 additions & 10 deletions

File tree

cmd/kv.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ import "github.com/spf13/cobra"
44

55
func newKVCmd(children ...*cobra.Command) *cobra.Command {
66
cmd := &cobra.Command{
7-
Use: "kv",
8-
Aliases: []string{"keyvalues", "keyvalue"},
9-
Short: "Manage Render Key Value instances (early access)",
7+
Use: "keyvalues",
8+
Aliases: []string{"kv", "keyvalue"},
9+
Short: "Manage Render Key Value instances (alias: kv)",
1010
}
1111
cmd.AddCommand(children...)
1212
return cmd

cmd/pg.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ import "github.com/spf13/cobra"
44

55
func newPgCmd(children ...*cobra.Command) *cobra.Command {
66
cmd := &cobra.Command{
7-
Use: "pg",
8-
Aliases: []string{"postgres"},
9-
Short: "Manage Render Postgres databases",
7+
Use: "postgres",
8+
Aliases: []string{"pg"},
9+
Short: "Manage Render Postgres databases (alias: pg)",
1010
Long: `Manage Render Postgres databases.
1111
1212
Lives under 'ea' while the command surface stabilizes. Postgres itself is

cmd/pgcreate_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ func executePGCreate(t *testing.T, server *renderapi.Server, extraArgs ...string
1717
server.Owners.Add(renderapi.NewOwner(client.Owner{Id: pgActiveWorkspaceID, Name: "Test Workspace"}))
1818
t.Setenv("RENDER_WORKSPACE", pgActiveWorkspaceID)
1919

20-
return executePGCommand(t, server, append([]string{"ea", "pg", "create"}, extraArgs...)...)
20+
return executePGCommand(t, server, append([]string{"ea", "postgres", "create"}, extraArgs...)...)
2121
}
2222

2323
func TestPGCreate_ZeroFlags_AppliesDefaults(t *testing.T) {
@@ -126,13 +126,13 @@ func TestPGCreate_InteractiveConfirm_PrintsTextSuccess(t *testing.T) {
126126
assert.Contains(t, result.Stdout, pg.Id)
127127
}
128128

129-
func TestPGCreate_PostgresAlias(t *testing.T) {
129+
func TestPGCreate_PGAlias(t *testing.T) {
130130
server := renderapi.NewServer(t)
131131
server.Owners.Add(renderapi.NewOwner(client.Owner{Id: pgActiveWorkspaceID, Name: "Test Workspace"}))
132132
t.Setenv("RENDER_WORKSPACE", pgActiveWorkspaceID)
133133

134134
_, err := executePGCommand(t, server,
135-
"ea", "postgres", "create",
135+
"ea", "pg", "create",
136136
"--name", "alias-pg",
137137
"--output", "text",
138138
)
@@ -156,7 +156,7 @@ func TestPGCreate_ParameterOverrideFlagIsUnknown(t *testing.T) {
156156

157157
func TestPGCreate_NoWorkspaceConfigured(t *testing.T) {
158158
server := renderapi.NewServer(t)
159-
result, err := executePGCommand(t, server, "ea", "pg", "create", "--output", "text")
159+
result, err := executePGCommand(t, server, "ea", "postgres", "create", "--output", "text")
160160
require.Error(t, err)
161161
assert.Contains(t, result.Stderr, "no workspace")
162162
assert.Empty(t, server.Postgres.Instances)

0 commit comments

Comments
 (0)