remove dead code (#478)

During GROW-2587 work, I migrated from an old output shape to a new output shape. Which caused me to cut over all KV commands to use a couple of new resolve and format methods to deal with the new API shapes.

Now that everything is converted, those old helpers are unused code!

Completes GROW-2587

GitOrigin-RevId: c363f9603150b737c841fbe73e6bb48db732b718

Author: davidharting

pkg/keyvalue/resolve.go

@@ -75,34 +75,6 @@ func (s *Service) enrichResolvedKeyValue(ctx context.Context, resolved *Resolved
 	return nil
 }
 
-// Resolve looks up a Key Value instance by ID or name within an optional
-// project/environment scope.
-//
-// If env is supplied, Key Value name lookup is narrowed to that environment,
-// and an ID lookup is rejected unless the Key Value belongs to that
-// environment. If only project is supplied, name lookup is narrowed to all
-// environments in that project, and ID lookup is rejected unless the Key Value
-// belongs to one of them. If both are supplied, env is the concrete Key Value
-// scope; the caller is responsible for resolving env relative to project
-// before calling Resolve.
-func Resolve(
-	ctx context.Context,
-	idOrName string,
-	project *client.Project,
-	env *client.Environment,
-) (*client.KeyValueDetail, error) {
-	c, err := client.NewDefaultClient()
-	if err != nil {
-		return nil, err
-	}
-	repo := NewRepo(c)
-	return resolveInScope(ctx, repo, idOrName, resolveScope{project: project, env: env})
-}
-
-func resolveWithRepo(ctx context.Context, repo *Repo, idOrName string, env *client.Environment) (*client.KeyValueDetail, error) {
-	return resolveInScope(ctx, repo, idOrName, resolveScope{env: env})
-}
-
 func resolveInScope(
 	ctx context.Context,
 	repo *Repo,

pkg/text/keyvalue.go

@@ -6,7 +6,6 @@ import (
 
 	"github.com/jedib0t/go-pretty/table"
 
-	"github.com/render-oss/cli/pkg/client"
 	"github.com/render-oss/cli/pkg/keyvalue"
 )
 
@@ -27,26 +26,6 @@ func KeyValueTable(v []keyvalue.KeyValueOut) string {
 	return FormatString(t.Render())
 }
 
-// KeyValueAPIDetail formats a raw API KV instance detail for text output.
-// Does NOT include an action prefix (e.g., "Created" or "Updated") — callers should prepend
-// their own action prefix in the formatText closure passed to command.NonInteractive.
-//
-// Prefer converting callers to keyvalue.KeyValueOut and using KeyValueDetail.
-func KeyValueAPIDetail(kv *client.KeyValueDetail) string {
-	lines := []string{
-		fmt.Sprintf("Name: %s", kv.Name),
-		fmt.Sprintf("ID: %s", kv.Id),
-		fmt.Sprintf("Plan: %s", string(kv.Plan)),
-		fmt.Sprintf("Region: %s", string(kv.Region)),
-		fmt.Sprintf("Status: %s", string(kv.Status)),
-	}
-	if kv.Options.MaxmemoryPolicy != nil {
-		lines = append(lines, fmt.Sprintf("Memory policy: %s", *kv.Options.MaxmemoryPolicy))
-	}
-	lines = append(lines, ipAllowListBlock(kv.IpAllowList))
-	return strings.Join(lines, "\n")
-}
-
 func KeyValueDetail(kv *keyvalue.KeyValueOut) string {
 	lines := []string{
 		fmt.Sprintf("Name: %s", kv.Name),