Text makes sense as the default cli output format, we should only try and be smart about the cli output format if we're confident it's being run by an agnent (#278)

Author: mosslilley

cmd/root.go

@@ -239,7 +239,7 @@ func init() {
 
 	rootCmd.Version = cfg.Version
 	rootCmd.CompletionOptions.DisableDefaultCmd = true
-	rootCmd.PersistentFlags().StringP("output", "o", "interactive", "interactive, json, yaml, or text (auto: json in non-TTY contexts)")
+	rootCmd.PersistentFlags().StringP("output", "o", "interactive", "interactive, json, yaml, or text (auto: text in non-TTY contexts)")
 	rootCmd.PersistentFlags().Bool(command.ConfirmFlag, false, "set to skip confirmation prompts")
 
 	// Flags from the old CLI that we error with a helpful message

cmd/root_test.go

@@ -20,7 +20,7 @@ func TestRootPersistentPreRunOutputResolution(t *testing.T) {
 		wantStackContext bool
 	}{
 		{
-			name: "default output with unchanged flag uses auto mode and resolves json for non-tty",
+			name: "default output with unchanged flag uses auto mode and resolves text for non-tty",
 			input: runRootPersistentPreRunInput{
 				explicitOutput: false,
 				outputValue:    "interactive",
@@ -30,7 +30,7 @@ func TestRootPersistentPreRunOutputResolution(t *testing.T) {
 					StderrTTY: true,
 				},
 			},
-			wantOutput: command.JSON,
+			wantOutput: command.TEXT,
 		},
 		{
 			name: "explicit interactive remains interactive regardless of non-tty ci signals",
@@ -104,7 +104,7 @@ func TestRootPersistentPreRunOutputResolution(t *testing.T) {
 			wantOutput: command.YAML,
 		},
 		{
-			name: "ci truthy in auto mode resolves json",
+			name: "ci truthy in auto mode resolves text",
 			input: runRootPersistentPreRunInput{
 				explicitOutput: false,
 				outputValue:    "interactive",
@@ -115,7 +115,7 @@ func TestRootPersistentPreRunOutputResolution(t *testing.T) {
 					CI:        true,
 				},
 			},
-			wantOutput: command.JSON,
+			wantOutput: command.TEXT,
 		},
 		{
 			name: "all tty and ci false in auto mode resolves interactive",

pkg/command/outputresolver.go

@@ -60,7 +60,7 @@ func ResolveAutoOutput(explicitOutputSet bool, requested Output, signals Runtime
 		return Interactive, nil
 	}
 
-	return JSON, nil
+	return TEXT, nil
 }
 
 func isSupportedOutput(output Output) bool {

pkg/command/outputresolver_test.go

@@ -229,7 +229,7 @@ func TestResolveAutoOutput(t *testing.T) {
 				StdoutTTY: true,
 				StderrTTY: true,
 			},
-			wantOutput: command.JSON,
+			wantOutput: command.TEXT,
 		},
 		{
 			name:            "all tty and ci false resolves interactive",
@@ -243,40 +243,40 @@ func TestResolveAutoOutput(t *testing.T) {
 			wantOutput: command.Interactive,
 		},
 		{
-			name:            "non-tty stdin resolves json",
+			name:            "non-tty stdin resolves text",
 			explicitOutput:  false,
 			requestedOutput: command.Interactive,
 			signals: command.RuntimeSignals{
 				StdinTTY:  false,
 				StdoutTTY: true,
 				StderrTTY: true,
 			},
-			wantOutput: command.JSON,
+			wantOutput: command.TEXT,
 		},
 		{
-			name:            "non-tty stdout resolves json",
+			name:            "non-tty stdout resolves text",
 			explicitOutput:  false,
 			requestedOutput: command.Interactive,
 			signals: command.RuntimeSignals{
 				StdinTTY:  true,
 				StdoutTTY: false,
 				StderrTTY: true,
 			},
-			wantOutput: command.JSON,
+			wantOutput: command.TEXT,
 		},
 		{
-			name:            "non-tty stderr resolves json",
+			name:            "non-tty stderr resolves text",
 			explicitOutput:  false,
 			requestedOutput: command.Interactive,
 			signals: command.RuntimeSignals{
 				StdinTTY:  true,
 				StdoutTTY: true,
 				StderrTTY: false,
 			},
-			wantOutput: command.JSON,
+			wantOutput: command.TEXT,
 		},
 		{
-			name:            "ci true resolves json",
+			name:            "ci true resolves text",
 			explicitOutput:  false,
 			requestedOutput: command.Interactive,
 			signals: command.RuntimeSignals{
@@ -285,10 +285,10 @@ func TestResolveAutoOutput(t *testing.T) {
 				StderrTTY: true,
 				CI:        true,
 			},
-			wantOutput: command.JSON,
+			wantOutput: command.TEXT,
 		},
 		{
-			name:            "TERM=dumb resolves json even with all TTYs",
+			name:            "TERM=dumb resolves text even with all TTYs",
 			explicitOutput:  false,
 			requestedOutput: command.Interactive,
 			signals: command.RuntimeSignals{
@@ -297,7 +297,7 @@ func TestResolveAutoOutput(t *testing.T) {
 				StderrTTY:    true,
 				DumbTerminal: true,
 			},
-			wantOutput: command.JSON,
+			wantOutput: command.TEXT,
 		},
 		{
 			name:            "invalid requested output returns error",