[CAP-9383] allow matching tasks by plain name in local dev server store (#322)

Add plain name matching to `GetTask` in addition to service/task matching. Tasks defined in a local environment aren't guaranteed to have workflow service slugs.

GitOrigin-RevId: 3691221446432a0d5bcf98846635aa0c6a3c8cc2

Author: blue-keleher

pkg/workflows/orchestrator/coordinator_test.go

@@ -108,7 +108,7 @@ func TestStartTask(t *testing.T) {
 		&noopStatusReporter{},
 	)
 
-	_, err = coordinator.StartTask(ctx, "fake-workflow/test-task", []byte{}, nil)
+	_, err = coordinator.StartTask(ctx, "test-task", []byte{}, nil)
 	require.NoError(t, err)
 
 	ts := s.GetTasks()
@@ -216,7 +216,7 @@ func TestStartTaskWithSubtask(t *testing.T) {
 
 	// Trigger a task and then we will simulate a subtask
 	go func() {
-		_, err = coordinator.StartTask(ctx, "fake-workflow/test-task", []byte{}, nil)
+		_, err = coordinator.StartTask(ctx, "test-task", []byte{}, nil)
 		require.NoError(t, err)
 	}()
 
@@ -348,7 +348,7 @@ func TestStartTaskProcessExits(t *testing.T) {
 		&noopStatusReporter{},
 	)
 
-	taskRun, err := coordinator.StartTask(ctx, "fake-workflow/test-task", []byte{}, nil)
+	taskRun, err := coordinator.StartTask(ctx, "test-task", []byte{}, nil)
 	require.NoError(t, err)
 
 	// The background goroutine should detect the process exit and fail the task run

pkg/workflows/store/store.go

@@ -3,8 +3,8 @@ package store
 import (
 	"encoding/json"
 	"fmt"
-	"regexp"
 	"slices"
+	"strings"
 	"sync"
 	"time"
 
@@ -184,14 +184,19 @@ func (s *TaskStore) GetTask(taskID string) *Task {
 	s.mu.Lock()
 	defer s.mu.Unlock()
 
-	for i := range s.tasks {
-		if s.tasks[i].ID == taskID {
-			return s.tasks[i]
-		}
+	// Strip workflow prefix (e.g. "workflow-name/task-name") and match by
+	// plain task name so production slugs work against local dev.
+	var name string
+	hasStrippedName := false
+	if idx := strings.LastIndex(taskID, "/"); idx != -1 {
+		name = taskID[idx+1:]
+		hasStrippedName = true
 	}
 
-	for _, task := range s.tasks {
-		if regexp.MustCompile(fmt.Sprintf("^.*/%s(:.*)?$", task.Name)).MatchString(taskID) {
+	for i := range s.tasks {
+		task := s.tasks[i]
+
+		if task.ID == taskID || task.Name == taskID || (hasStrippedName && task.Name == name) {
 			return task
 		}
 	}

pkg/workflows/store/store_test.go

@@ -141,6 +141,38 @@ func TestGetTask(t *testing.T) {
 		},
 	})
 
-	task := s.GetTask("foo/test")
-	require.Equal(t, "test", task.Name)
+	t.Run("by name", func(t *testing.T) {
+		task := s.GetTask("test")
+		require.NotNil(t, task)
+		require.Equal(t, "test", task.Name)
+	})
+
+	t.Run("by ID", func(t *testing.T) {
+		tasks := s.GetTasks()
+		task := s.GetTask(tasks[0].ID)
+		require.NotNil(t, task)
+		require.Equal(t, "test", task.Name)
+	})
+
+	t.Run("by slug with workflow prefix", func(t *testing.T) {
+		task := s.GetTask("my-workflow/test")
+		require.NotNil(t, task)
+		require.Equal(t, "test", task.Name)
+	})
+
+	t.Run("by slug with multi-segment prefix", func(t *testing.T) {
+		task := s.GetTask("org/my-workflow/test")
+		require.NotNil(t, task)
+		require.Equal(t, "test", task.Name)
+	})
+
+	t.Run("not found", func(t *testing.T) {
+		task := s.GetTask("nonexistent")
+		require.Nil(t, task)
+	})
+
+	t.Run("slug not found", func(t *testing.T) {
+		task := s.GetTask("my-workflow/nonexistent")
+		require.Nil(t, task)
+	})
 }