Add Key Value output contract for create (#476)

Tightens up JSON / YAML output for `kv create` command.

Updates `render ea kv create -o json` to serialize and print the new `KeyValueOut` struct, instead of just printing whatever is returned by the API

GROW-2587

GitOrigin-RevId: e554e898f89881362375e9bb0e213691eeabab64

Author: davidharting

cmd/kvcreate.go

@@ -5,7 +5,6 @@ import (
 
 	"github.com/spf13/cobra"
 
-	"github.com/render-oss/cli/pkg/client"
 	"github.com/render-oss/cli/pkg/command"
 	"github.com/render-oss/cli/pkg/dependencies"
 	"github.com/render-oss/cli/pkg/keyvalue"
@@ -15,7 +14,7 @@ import (
 	kvtypes "github.com/render-oss/cli/pkg/types/keyvalue"
 )
 
-func newKVCreateCmd(_ *dependencies.Dependencies) *cobra.Command {
+func newKVCreateCmd(deps *dependencies.Dependencies) *cobra.Command {
 	cmd := &cobra.Command{
 		Use:   "create",
 		Short: "Create a new Key Value store instance",
@@ -75,10 +74,15 @@ Examples:
 		}
 
 		if nonInteractive, err := command.NonInteractive(cmd,
-			func() (*client.KeyValueDetail, error) {
-				return keyvalue.Create(cmd.Context(), input)
+			func() (*keyvalue.KeyValueOut, error) {
+				resolved, err := deps.KeyValueService().Create(cmd.Context(), input)
+				if err != nil {
+					return nil, err
+				}
+				out := keyvalue.NewKeyValueOut(resolved)
+				return &out, nil
 			},
-			func(kv *client.KeyValueDetail) string {
+			func(kv *keyvalue.KeyValueOut) string {
 				return kvCreateSuccessMessage(kv)
 			},
 		); err != nil {
@@ -88,7 +92,7 @@ Examples:
 		}
 
 		if command.GetConfirmFromContext(cmd.Context()) {
-			return runKVCreateAndPrint(cmd, input)
+			return runKVCreateAndPrint(cmd, deps, input)
 		}
 
 		kv, err := views.RunKeyValueCreate(cmd, &input)
@@ -99,25 +103,27 @@ Examples:
 			_, _ = fmt.Fprintln(cmd.OutOrStdout(), "Canceled.")
 			return nil
 		}
-		_, _ = fmt.Fprint(cmd.OutOrStdout(), kvCreateSuccessMessage(kv))
+		out := keyvalue.NewKeyValueOut(&keyvalue.ResolvedKeyValue{KeyValue: kv})
+		_, _ = fmt.Fprint(cmd.OutOrStdout(), kvCreateSuccessMessage(&out))
 		return nil
 	}
 
 	return cmd
 }
 
-func runKVCreateAndPrint(cmd *cobra.Command, input kvtypes.KeyValueCreateInput) error {
-	kv, err := keyvalue.Create(cmd.Context(), input)
+func runKVCreateAndPrint(cmd *cobra.Command, deps *dependencies.Dependencies, input kvtypes.KeyValueCreateInput) error {
+	resolved, err := deps.KeyValueService().Create(cmd.Context(), input)
 	if err != nil {
 		return err
 	}
-	_, _ = fmt.Fprint(cmd.OutOrStdout(), kvCreateSuccessMessage(kv))
+	out := keyvalue.NewKeyValueOut(resolved)
+	_, _ = fmt.Fprint(cmd.OutOrStdout(), kvCreateSuccessMessage(&out))
 	return nil
 }
 
-func kvCreateSuccessMessage(kv *client.KeyValueDetail) string {
+func kvCreateSuccessMessage(kv *keyvalue.KeyValueOut) string {
 	return fmt.Sprintf(
 		"Created Key Value store\n\n%s\n",
-		text.KeyValueAPIDetail(kv),
+		text.KeyValueDetail(kv),
 	)
 }

cmd/kvcreate_test.go

@@ -4,6 +4,7 @@ import (
 	"encoding/json"
 	"net/http"
 	"testing"
+	"time"
 
 	renderapi "github.com/render-oss/cli/internal/fakes/renderapi"
 	"github.com/render-oss/cli/internal/testids"
@@ -363,14 +364,46 @@ func TestKVCreate_ConfirmMode_GeneratesName(t *testing.T) {
 
 func TestKVCreate_OutputJSON(t *testing.T) {
 	server := renderapi.NewServer(t)
+	project := server.CreateProject(
+		renderapi.ProjectAttrs{Name: "My Project", OwnerId: kvTestWorkspaceID},
+		renderapi.EnvAttrs{Name: "production"},
+	)
+	env := project.Env("production")
+
 	cmdResult, err := executeKVCreate(t, server,
-		"--name", "my-kv", "--plan", "free",
+		"--name", "my-kv",
+		"--plan", "free",
+		"--project", "My Project",
+		"--environment", "production",
+		"--memory-policy", "queue",
+		"--ip-allow-list", "cidr=203.0.113.5/32,description=office",
 		"--output", "json",
 	)
 	require.NoError(t, err)
-	var result map[string]interface{}
-	require.NoError(t, json.Unmarshal([]byte(cmdResult.Stdout), &result), "expected valid JSON, got: %s", cmdResult.Stdout)
-	assert.Equal(t, "my-kv", result["name"])
+
+	var body map[string]any
+	require.NoError(t, json.Unmarshal([]byte(cmdResult.Stdout), &body), "expected valid JSON, got: %s", cmdResult.Stdout)
+	require.Len(t, server.KV.Instances, 1)
+	kv := server.KV.Instances[0]
+	assert.Equal(t, map[string]any{
+		"id":            kv.Id,
+		"name":          "my-kv",
+		"plan":          "free",
+		"region":        "oregon",
+		"status":        "available",
+		"createdAt":     kv.CreatedAt.Format(time.RFC3339Nano),
+		"updatedAt":     kv.UpdatedAt.Format(time.RFC3339Nano),
+		"ownerId":       kvTestWorkspaceID,
+		"projectId":     project.Project.Id,
+		"environmentId": env.Id,
+		"ipAllowList": []any{
+			map[string]any{
+				"cidrBlock":   "203.0.113.5/32",
+				"description": "office",
+			},
+		},
+		"maxmemoryPolicy": "noeviction",
+	}, body)
 }
 
 func TestKVCreate_OutputYAML(t *testing.T) {

pkg/keyvalue/create.go

@@ -13,17 +13,22 @@ import (
 )
 
 // Create applies defaults, resolves the requested scope (workspace/project/
-// environment), and calls the Key Value create endpoint. It is the shared
-// entry point for both the non-interactive flag path and the interactive
-// wizard's final submit step.
+// environment), and calls the Key Value create endpoint.
 func Create(ctx context.Context, input kvtypes.KeyValueCreateInput) (*client.KeyValueDetail, error) {
-	input = kvtypes.NormalizeCreateInput(input)
-
 	c, err := client.NewDefaultClient()
 	if err != nil {
 		return nil, err
 	}
-	resolver := resolve.NewFromClient(c)
+	svc := NewService(NewRepo(c), nil, nil, resolve.NewFromClient(c))
+	resolved, err := svc.Create(ctx, input)
+	if err != nil {
+		return nil, err
+	}
+	return resolved.KeyValue, nil
+}
+
+func (s *Service) create(ctx context.Context, input kvtypes.KeyValueCreateInput) (*ResolvedKeyValue, error) {
+	input = kvtypes.NormalizeCreateInput(input)
 
 	if input.Name == "" {
 		input.Name = petname.Generate(2, "-")
@@ -40,7 +45,7 @@ func Create(ctx context.Context, input kvtypes.KeyValueCreateInput) (*client.Key
 		input.MaxmemoryPolicy = &p
 	}
 
-	scope, err := resolver.ResolveScope(ctx, resolve.ScopeInput{
+	scope, err := s.resolver.ResolveScope(ctx, resolve.ScopeInput{
 		WorkspaceIDOrName:   input.WorkspaceIDOrName,
 		ProjectIDOrName:     input.ProjectIDOrName,
 		EnvironmentIDOrName: input.EnvironmentIDOrName,
@@ -51,7 +56,7 @@ func Create(ctx context.Context, input kvtypes.KeyValueCreateInput) (*client.Key
 
 	environmentID := scope.EnvironmentID()
 	if environmentID == nil && input.ProjectIDOrName != nil && input.EnvironmentIDOrName == nil {
-		environmentID, err = resolver.ResolveEnvironmentID(ctx, scope.Project, nil, scope.WorkspaceID)
+		environmentID, err = s.resolver.ResolveEnvironmentID(ctx, scope.Project, nil, scope.WorkspaceID)
 		if err != nil {
 			return nil, err
 		}
@@ -70,7 +75,15 @@ func Create(ctx context.Context, input kvtypes.KeyValueCreateInput) (*client.Key
 		return nil, err
 	}
 
-	return NewRepo(c).CreateKeyValue(ctx, body)
+	kv, err := s.repo.CreateKeyValue(ctx, body)
+	if err != nil {
+		return nil, err
+	}
+	return &ResolvedKeyValue{
+		KeyValue:    kv,
+		Project:     scope.Project,
+		Environment: scope.Environment,
+	}, nil
 }
 
 var wellKnownPlanValues = []string{

pkg/keyvalue/service.go

@@ -88,6 +88,12 @@ func (s *Service) Resolve(ctx context.Context, input ResolveInput) (*ResolvedKey
 	return s.resolve(ctx, input)
 }
 
+// Create applies defaults, resolves the requested scope, creates a Key Value,
+// and returns the created resource with resolved project/environment context.
+func (s *Service) Create(ctx context.Context, input kvtypes.KeyValueCreateInput) (*ResolvedKeyValue, error) {
+	return s.create(ctx, input)
+}
+
 func (s *Service) GetConnectionInfo(ctx context.Context, id string) (*client.KeyValueConnectionInfo, error) {
 	return s.repo.GetKeyValueConnectionInfo(ctx, id)
 }