chore(dev): run markdownlint on git files only (vectordotdev#23004)

Author: pront

vdev/src/commands/check/markdown.rs

@@ -1,6 +1,7 @@
 use anyhow::Result;
 
 use crate::app;
+use crate::git::git_ls_files;
 
 /// Check that markdown is styled properly
 #[derive(clap::Args, Debug)]
@@ -9,20 +10,22 @@ pub struct Cli {}
 
 impl Cli {
     pub fn exec(self) -> Result<()> {
-        app::exec(
-            "markdownlint",
-            [
-                "--config",
-                "scripts/.markdownlintrc",
-                "--ignore",
-                "scripts/node_modules",
-                "--ignore",
-                "website/node_modules",
-                "--ignore",
-                "target",
-                ".",
-            ],
-            true,
-        )
+        let files = git_ls_files(Some("*.md"))?;
+        if files.is_empty() {
+            return Ok(());
+        }
+
+        let args: Vec<&str> = vec![
+            "--config",
+            "scripts/.markdownlintrc",
+            // We should fix these as well. Previously these files were not linted.
+            "--ignore",
+            ".github"
+        ]
+            .into_iter()
+            .chain(files.iter().map(String::as_str))
+            .collect();
+
+        app::exec("markdownlint", &args, true)
     }
 }

vdev/src/git.rs

@@ -165,3 +165,14 @@ pub fn run_and_check_output(args: &[&str]) -> Result<String> {
 fn is_warning_line(line: &str) -> bool {
     line.starts_with("warning: ") || line.contains("original line endings")
 }
+
+/// Returns a list of tracked files. If `pattern` is specified, it filters using that pattern.
+pub fn git_ls_files(pattern: Option<&str>) -> Result<Vec<String>> {
+    let args = match pattern {
+        Some(p) => vec!["ls-files", p],
+        None => vec!["ls-files"],
+    };
+
+    let output = run_and_check_output(&args)?;
+    Ok(output.lines().map(str::to_owned).collect())
+}