Add ChatGPT Atlas browser support#71
Conversation
|
/prerelease |
1 similar comment
|
/prerelease |
|
Prerelease |
|
Hi @rowesk, thanks for bringing this up! Could you test the prerelease to see if this works correctly and to make sure you got the correct bundle id? |
|
Hi @renjfk, I tested the prerelease and found the bundle ID issue. What went wrong:
What I changed:
Verified locally:
Commit pushed: |
| <string>com.brave.Browser</string> | ||
| <string>com.vivaldi.Vivaldi</string> | ||
| <string>org.mozilla.firefox</string> | ||
| <string>com.openai.atlas</string> |
There was a problem hiding this comment.
Do we need the wrapper app id in AppleEvents entitlements? AtlasBrowser now targets tell application id "com.openai.atlas.web", so com.openai.atlas.web seems to be the required sandbox exception. com.openai.atlas still makes sense for frontmost-app detection, but I do not see an AppleEvent call targeting it.
| } | ||
|
|
||
| for bundleId in AtlasBrowser.supportedBundleIds { | ||
| browsers[bundleId] = atlasBrowser |
There was a problem hiding this comment.
Do we have evidence that NSWorkspace.frontmostApplication.bundleIdentifier can return com.openai.atlas.web? If the frontmost app is always the visible wrapper com.openai.atlas, then we should keep only com.openai.atlas for browser detection and use com.openai.atlas.web only as the AppleScript target/entitlement.
Summary
WebTrackingServiceusing bundle idcom.openai.atlas.Why
ChatGPT Atlas is Chromium-based and supports the same AppleScript URL lookup shape as Chrome (
URL of active tab of window 1), but SimplyTrack did not include Atlas in its supported-browser registry or Automation entitlement list. That meant Atlas activity was recorded only as app usage, not website/domain usage.Testing
osascript -e 'id of application "ChatGPT Atlas"'→com.openai.atlas.webosascript -e 'tell application "ChatGPT Atlas" to if (count of windows) > 0 then return URL of active tab of window 1'returned the active tab URL.BrowserSupportTests/chatGPTAtlasIsRecognizedAsSupportedBrowser()before implementation.xcodebuild -project SimplyTrack.xcodeproj -scheme SimplyTrack -configuration Debug -skip-testing:SimplyTrackUITests CODE_SIGNING_ALLOWED=NO test→** TEST SUCCEEDED **xcodebuild -project SimplyTrack.xcodeproj -scheme SimplyTrack -configuration Debug CODE_SIGNING_ALLOWED=NO build→ succeeded.git diff --check→ clean.Notes
com.openai.atlas; AppleScript'sid of application "ChatGPT Atlas"reportscom.openai.atlas.web, so this PR uses the NSWorkspace/frontmost app bundle id for SimplyTrack registration and entitlement targeting.