fix: increase rateLimit burst size to 2 (GoogleCloudPlatform#1048)

Author: enocom

go.mod

@@ -10,6 +10,7 @@ require (
 	github.com/hanwen/go-fuse/v2 v2.1.0
 	github.com/lib/pq v1.10.4
 	go.uber.org/zap v1.19.1
+	golang.org/x/crypto v0.0.0-20210711020723-a769d52b0f97 // indirect
 	golang.org/x/net v0.0.0-20211020060615-d418f374d309
 	golang.org/x/oauth2 v0.0.0-20211104180415-d3ed0bb246c8
 	golang.org/x/sys v0.0.0-20211216021012-1d35b9e2eb4e

go.sum

@@ -221,8 +221,9 @@ golang.org/x/crypto v0.0.0-20190325154230-a5d413f7728c/go.mod h1:djNgcEr1/C05ACk
 golang.org/x/crypto v0.0.0-20190510104115-cbcb75029529/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
 golang.org/x/crypto v0.0.0-20190605123033-f99c8df09eb5/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
 golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8UmvKecakEJjdnWj3jj499lnFckfCI=
-golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9 h1:psW17arqaxU48Z5kZ0CQnkZWQJsqcURM6tKiBApRjXI=
 golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
+golang.org/x/crypto v0.0.0-20210711020723-a769d52b0f97 h1:/UOmuWzQfxxo9UtlXMwuQU8CMgg1eZXqTRwkSQJWKOI=
+golang.org/x/crypto v0.0.0-20210711020723-a769d52b0f97/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=
 golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
 golang.org/x/exp v0.0.0-20190306152737-a1d7652674e8/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
 golang.org/x/exp v0.0.0-20190510132918-efd6b22b2522/go.mod h1:ZjyILWgesfNpC6sMxTJOJm9Kp84zZh5NQWvqDGG3Qr8=
@@ -365,6 +366,7 @@ golang.org/x/sys v0.0.0-20210423082822-04245dca01da/go.mod h1:h1NjWce9XRLGQEsW7w
 golang.org/x/sys v0.0.0-20210510120138-977fb7262007/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20210514084401-e8d321eab015/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20210603125802-9665404d3644/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20210616094352-59db8d763f22/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20210630005230-0f9fa26af87c/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20210806184541-e5e7981a1069/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=

proxy/proxy/client.go

@@ -417,7 +417,7 @@ func (c *Client) cachedCfg(ctx context.Context, instance string) (string, *tls.C
 		e = c.cfgCache[instance]
 		limiter := c.limiters[instance]
 		if limiter == nil {
-			limiter = rate.NewLimiter(rate.Every(throttle), 1)
+			limiter = rate.NewLimiter(rate.Every(throttle), 2)
 			c.limiters[instance] = limiter
 		}
 		if needsRefresh(e, refreshCfgBuffer) {

proxy/proxy/client_test.go

@@ -559,25 +559,13 @@ func TestClientHandshakeCanceled(t *testing.T) {
 			validateError(t, err)
 		})
 	})
+}
 
-	// Fail fast when dial attempts trigger a race condition
-	t.Run("dialing in quick succession", func(t *testing.T) {
-		withTestHarness(t, func(port int) {
-			c := newClient(port)
-
-			ctx, cancel := context.WithTimeout(context.Background(), time.Second)
-			defer cancel()
+func TestConnectingWithInvalidConfig(t *testing.T) {
+	c := &Client{}
 
-			var ok bool
-			for i := 0; i < 100; i++ {
-				_, err := c.DialContext(ctx, instance)
-				if err == ErrUnexpectedFailure {
-					ok = true
-				}
-			}
-			if !ok {
-				t.Fatal("wanted ErrUnexpectedFailure, got none")
-			}
-		})
-	})
+	_, err := c.tryConnect(context.Background(), "", "myinstance", &tls.Config{})
+	if err != ErrUnexpectedFailure {
+		t.Fatalf("wanted ErrUnexpectedFailure, got = %v", err)
+	}
 }