impl(v3): delete absl quiet headers (googleapis#15897)

Author: scotthart

ci/cloudbuild/builds/checkers.sh

@@ -94,19 +94,6 @@ time {
     xargs -r -P "$(nproc)" -n 50 -0 awk -f "ci/check-include-guards.gawk"
 }
 
-# TODO(#4501) - this fixup can be removed if #include <absl/...> works
-# Apply transformations to fix errors on MSVC+x86. See the bug for a detailed
-# explanation as to why this is needed:
-#   https://github.com/googleapis/google-cloud-cpp/issues/4501
-# This should run before clang-format because it might alter the order of any
-# includes.
-printf "%-50s" "Running Abseil header fixes:" >&2
-time {
-  expressions=("-e" "'s;#include \"absl/strings/str_\(cat\|replace\|join\).h\";#include \"google/cloud/internal/absl_str_\1_quiet.h\";'")
-  (git grep -zEl '#include "absl/strings/str_(cat|replace|join).h"' -- '*.h' '*.cc' ':!google/cloud/internal/absl_str_*quiet.h' || true) |
-    xargs -r -P "$(nproc)" -n 50 -0 bash -c "sed_edit ${expressions[*]} \"\$0\" \"\$@\""
-}
-
 # Apply several transformations that cannot be enforced by clang-format:
 #     - Replace any #include for grpc++/* with grpcpp/*. The paths with grpc++
 #       are obsoleted by the gRPC team, so we should not use them in our code.

generator/generator.cc

@@ -17,10 +17,10 @@
 #include "generator/internal/descriptor_utils.h"
 #include "generator/internal/generator_interface.h"
 #include "generator/internal/make_generators.h"
-#include "google/cloud/internal/absl_str_cat_quiet.h"
 #include "google/cloud/internal/algorithm.h"
 #include "google/cloud/internal/filesystem.h"
 #include "google/cloud/status_or.h"
+#include "absl/strings/str_cat.h"
 #include "absl/strings/str_split.h"
 #include "google/api/client.pb.h"
 #include <future>

generator/integration_tests/golden/v1/internal/deprecated_metadata_decorator.cc

@@ -17,8 +17,9 @@
 // source: generator/integration_tests/test_deprecated.proto
 
 #include "generator/integration_tests/golden/v1/internal/deprecated_metadata_decorator.h"
+#include "absl/strings/str_cat.h"
+#include "absl/strings/str_join.h"
 #include "google/cloud/grpc_options.h"
-#include "google/cloud/internal/absl_str_cat_quiet.h"
 #include "google/cloud/internal/api_client_header.h"
 #include "google/cloud/internal/url_encode.h"
 #include "google/cloud/status_or.h"

generator/integration_tests/golden/v1/internal/deprecated_rest_metadata_decorator.cc

@@ -17,8 +17,8 @@
 // source: generator/integration_tests/test_deprecated.proto
 
 #include "generator/integration_tests/golden/v1/internal/deprecated_rest_metadata_decorator.h"
+#include "absl/strings/str_cat.h"
 #include "absl/strings/str_format.h"
-#include "google/cloud/internal/absl_str_cat_quiet.h"
 #include "google/cloud/internal/api_client_header.h"
 #include "google/cloud/internal/rest_set_metadata.h"
 #include "google/cloud/status_or.h"

generator/integration_tests/golden/v1/internal/deprecated_rest_stub.cc

@@ -17,8 +17,8 @@
 // source: generator/integration_tests/test_deprecated.proto
 
 #include "generator/integration_tests/golden/v1/internal/deprecated_rest_stub.h"
+#include "absl/strings/str_cat.h"
 #include "google/cloud/common_options.h"
-#include "google/cloud/internal/absl_str_cat_quiet.h"
 #include "google/cloud/internal/rest_stub_helpers.h"
 #include "google/cloud/status_or.h"
 #include "generator/integration_tests/test_deprecated.pb.h"

generator/integration_tests/golden/v1/internal/golden_kitchen_sink_metadata_decorator.cc

@@ -17,9 +17,9 @@
 // source: generator/integration_tests/test.proto
 
 #include "generator/integration_tests/golden/v1/internal/golden_kitchen_sink_metadata_decorator.h"
+#include "absl/strings/str_cat.h"
+#include "absl/strings/str_join.h"
 #include "google/cloud/grpc_options.h"
-#include "google/cloud/internal/absl_str_cat_quiet.h"
-#include "google/cloud/internal/absl_str_join_quiet.h"
 #include "google/cloud/internal/api_client_header.h"
 #include "google/cloud/internal/routing_matcher.h"
 #include "google/cloud/internal/url_encode.h"

generator/integration_tests/golden/v1/internal/golden_kitchen_sink_rest_metadata_decorator.cc

@@ -17,8 +17,8 @@
 // source: generator/integration_tests/test.proto
 
 #include "generator/integration_tests/golden/v1/internal/golden_kitchen_sink_rest_metadata_decorator.h"
+#include "absl/strings/str_cat.h"
 #include "absl/strings/str_format.h"
-#include "google/cloud/internal/absl_str_cat_quiet.h"
 #include "google/cloud/internal/api_client_header.h"
 #include "google/cloud/internal/rest_set_metadata.h"
 #include "google/cloud/internal/routing_matcher.h"

generator/integration_tests/golden/v1/internal/golden_kitchen_sink_rest_stub.cc

@@ -17,8 +17,8 @@
 // source: generator/integration_tests/test.proto
 
 #include "generator/integration_tests/golden/v1/internal/golden_kitchen_sink_rest_stub.h"
+#include "absl/strings/str_cat.h"
 #include "google/cloud/common_options.h"
-#include "google/cloud/internal/absl_str_cat_quiet.h"
 #include "google/cloud/internal/rest_stub_helpers.h"
 #include "google/cloud/status_or.h"
 #include "generator/integration_tests/test.pb.h"

generator/integration_tests/golden/v1/internal/golden_rest_only_option_defaults.cc

@@ -21,7 +21,7 @@
 #include "generator/integration_tests/golden/v1/golden_rest_only_options.h"
 #include "google/cloud/internal/populate_common_options.h"
 #include "google/cloud/internal/populate_grpc_options.h"
-#include "google/cloud/internal/absl_str_cat_quiet.h"
+#include "absl/strings/str_cat.h"
 #include <memory>
 #include <utility>
 

generator/integration_tests/golden/v1/internal/golden_rest_only_rest_metadata_decorator.cc

@@ -17,8 +17,8 @@
 // source: generator/integration_tests/test2.proto
 
 #include "generator/integration_tests/golden/v1/internal/golden_rest_only_rest_metadata_decorator.h"
+#include "absl/strings/str_cat.h"
 #include "absl/strings/str_format.h"
-#include "google/cloud/internal/absl_str_cat_quiet.h"
 #include "google/cloud/internal/api_client_header.h"
 #include "google/cloud/internal/rest_set_metadata.h"
 #include "google/cloud/status_or.h"