Skip to content

Commit 5cd5046

Browse files
authored
impl(spanner): remove deprecated Admin classes (googleapis#15862)
* impl(spanner): remove deprecated Admin classes
1 parent a83d81f commit 5cd5046

26 files changed

Lines changed: 39 additions & 8011 deletions
-95.6 KB
Binary file not shown.

doc/v3-migration-guide.md

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,44 @@ file. It only contained internal symbols.
347347

348348
</details>
349349

350+
<details>
351+
<summary>Removed Admin Clients from <code>spanner</code> namespace</summary>
352+
353+
The `DatabaseAdminClient` and `InstanceAdminClient` classes (and their
354+
associated connection classes and factory functions) have been removed from the
355+
`google::cloud::spanner` namespace. Please use the replacements in
356+
`google::cloud::spanner_admin`.
357+
358+
**Before:**
359+
360+
```cpp
361+
#include "google/cloud/spanner/database_admin_client.h"
362+
#include "google/cloud/spanner/instance_admin_client.h"
363+
364+
namespace spanner = ::google::cloud::spanner;
365+
366+
void Function(spanner::DatabaseAdminClient db_admin,
367+
spanner::InstanceAdminClient in_admin) {
368+
// ...
369+
}
370+
```
371+
372+
**After:**
373+
374+
```cpp
375+
#include "google/cloud/spanner/admin/database_admin_client.h"
376+
#include "google/cloud/spanner/admin/instance_admin_client.h"
377+
378+
namespace spanner_admin = ::google::cloud::spanner_admin;
379+
380+
void Function(spanner_admin::DatabaseAdminClient db_admin,
381+
spanner_admin::InstanceAdminClient in_admin) {
382+
// ...
383+
}
384+
```
385+
386+
</details>
387+
350388
### Storage
351389

352390
<details>

google/cloud/spanner/CMakeLists.txt

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -106,20 +106,12 @@ add_library(
106106
create_instance_request_builder.h
107107
database.cc
108108
database.h
109-
database_admin_client.cc
110-
database_admin_client.h
111-
database_admin_connection.cc
112-
database_admin_connection.h
113109
date.h
114110
directed_read_replicas.h
115111
encryption_config.h
116112
iam_updater.h
117113
instance.cc
118114
instance.h
119-
instance_admin_client.cc
120-
instance_admin_client.h
121-
instance_admin_connection.cc
122-
instance_admin_connection.h
123115
internal/channel.h
124116
internal/connection_impl.cc
125117
internal/connection_impl.h
@@ -361,8 +353,6 @@ if (GOOGLE_CLOUD_CPP_WITH_MOCKS)
361353
# cmake-format: sort
362354
admin/mocks/mock_database_admin_connection.h
363355
admin/mocks/mock_instance_admin_connection.h
364-
mocks/mock_database_admin_connection.h
365-
mocks/mock_instance_admin_connection.h
366356
mocks/mock_spanner_connection.h
367357
mocks/row.h)
368358
export_list_to_bazel("google_cloud_cpp_spanner_mocks.bzl"
@@ -458,11 +448,7 @@ function (spanner_client_define_tests)
458448
commit_options_test.cc
459449
connection_options_test.cc
460450
create_instance_request_builder_test.cc
461-
database_admin_client_test.cc
462-
database_admin_connection_test.cc
463451
database_test.cc
464-
instance_admin_client_test.cc
465-
instance_admin_connection_test.cc
466452
instance_test.cc
467453
internal/connection_impl_test.cc
468454
internal/database_admin_logging_test.cc

google/cloud/spanner/database_admin_client.cc

Lines changed: 0 additions & 252 deletions
This file was deleted.

0 commit comments

Comments
 (0)