impl(spanner): remove deprecated MakeTestRow (googleapis#15850)

* impl(spanner): remove MakeTestRow which was been deprecated

Author: mpeddada1

ci/abi-dumps/google_cloud_cpp_spanner.expected.abi.dump.gz

@@ -264,6 +264,39 @@ guide:
 
 ### Spanner
 
+<details>
+<summary>Removed <code>spanner::MakeTestRow</code>
+</summary>
+
+The `spanner::MakeTestRow` functions have been removed. Please use
+`spanner_mocks::MakeRow` instead.
+
+**Before:**
+
+```cpp
+#include "google/cloud/spanner/row.h"
+
+// ...
+
+auto row = google::cloud::spanner::MakeTestRow(
+    {{"c0", google::cloud::spanner::Value(42)}});
+auto row2 = google::cloud::spanner::MakeTestRow(1, "foo", true);
+```
+
+**After:**
+
+```cpp
+#include "google/cloud/spanner/mocks/row.h"
+
+// ...
+
+auto row = google::cloud::spanner_mocks::MakeRow(
+    {{"c0", google::cloud::spanner::Value(42)}});
+auto row2 = google::cloud::spanner_mocks::MakeRow(1, "foo", true);
+```
+
+</details>
+
 <details>
 <summary>Removed <code>spanner::ClientOptions</code> class</summary>
 

doc/v3-migration-guide.md

@@ -18,6 +18,7 @@
 #include "google/cloud/spanner/row.h"
 #include "google/cloud/spanner/value.h"
 #include "google/cloud/version.h"
+#include <memory>
 #include <string>
 #include <utility>
 #include <vector>
@@ -27,9 +28,6 @@ namespace cloud {
 namespace spanner_mocks {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 
-// TODO(#9086): Delete this when the MakeRow() implementation is moved here.
-#include "google/cloud/internal/disable_deprecation_warnings.inc"
-
 /**
  * Creates a `spanner::Row` with the specified column names and values.
  *
@@ -41,7 +39,14 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
  */
 inline spanner::Row MakeRow(
     std::vector<std::pair<std::string, spanner::Value>> pairs) {
-  return spanner::MakeTestRow(std::move(pairs));
+  auto values = std::vector<spanner::Value>{};
+  auto columns = std::make_shared<std::vector<std::string>>();
+  for (auto& p : pairs) {
+    values.emplace_back(std::move(p.second));
+    columns->emplace_back(std::move(p.first));
+  }
+  return spanner_internal::RowFriend::MakeRow(std::move(values),
+                                              std::move(columns));
 }
 
 /**
@@ -58,12 +63,14 @@ inline spanner::Row MakeRow(
  */
 template <typename... Ts>
 spanner::Row MakeRow(Ts&&... ts) {
-  return spanner::MakeTestRow(std::forward<Ts>(ts)...);
+  auto columns = std::make_shared<std::vector<std::string>>();
+  for (std::size_t i = 0; i < sizeof...(ts); ++i) {
+    columns->emplace_back(std::to_string(i));
+  }
+  std::vector<spanner::Value> v{spanner::Value(std::forward<Ts>(ts))...};
+  return spanner_internal::RowFriend::MakeRow(std::move(v), std::move(columns));
 }
 
-// TODO(#9086): Delete this when the MakeRow() implementation is moved here.
-#include "google/cloud/internal/diagnostics_pop.inc"
-
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace spanner_mocks
 }  // namespace cloud

google/cloud/spanner/mocks/row.h

@@ -35,16 +35,6 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 
 namespace spanner {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
-Row MakeTestRow(std::vector<std::pair<std::string, Value>> pairs) {
-  auto values = std::vector<Value>{};
-  auto columns = std::make_shared<std::vector<std::string>>();
-  for (auto& p : pairs) {
-    values.emplace_back(std::move(p.second));
-    columns->emplace_back(std::move(p.first));
-  }
-  return spanner_internal::RowFriend::MakeRow(std::move(values),
-                                              std::move(columns));
-}
 
 Row::Row() : Row({}, std::make_shared<std::vector<std::string>>()) {}
 

google/cloud/spanner/row.cc

@@ -200,41 +200,6 @@ class Row {
   std::shared_ptr<std::vector<std::string> const> columns_;
 };
 
-/**
- * Creates a `Row` with the specified column names and values.
- *
- * This overload accepts a vector of pairs, allowing the caller to specify both
- * the column names and the `Value` that goes in each column.
- *
- * This function is intended for application developers who are mocking the
- * results of a `Client::ExecuteQuery` call.
- */
-GOOGLE_CLOUD_CPP_SPANNER_MAKE_TEST_ROW_DEPRECATED()
-Row MakeTestRow(std::vector<std::pair<std::string, Value>> pairs);
-
-/**
- * Creates a `Row` with `Value`s created from the given arguments and with
- * auto-generated column names.
- *
- * This overload accepts a variadic list of arguments that will be used to
- * create the `Value`s in the row. The column names will be implicitly
- * generated, the first column being "0", the second "1", and so on,
- * corresponding to the argument's position.
- *
- * This function is intended for application developers who are mocking the
- * results of a `Client::ExecuteQuery` call.
- */
-template <typename... Ts>
-GOOGLE_CLOUD_CPP_SPANNER_MAKE_TEST_ROW_DEPRECATED()
-Row MakeTestRow(Ts&&... ts) {
-  auto columns = std::make_shared<std::vector<std::string>>();
-  for (std::size_t i = 0; i < sizeof...(ts); ++i) {
-    columns->emplace_back(std::to_string(i));
-  }
-  std::vector<Value> v{Value(std::forward<Ts>(ts))...};
-  return spanner_internal::RowFriend::MakeRow(std::move(v), std::move(columns));
-}
-
 /**
  * A `RowStreamIterator` is an _Input Iterator_ (see below) that returns a
  * sequence of `StatusOr<Row>` objects.