Skip to content

Commit c72fcb3

Browse files
fix(storage): Increase AsyncWriter default MinLwmValue to avoid frequent flushes (googleapis#15552)
1 parent feb385d commit c72fcb3

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

google/cloud/storage/internal/async/default_options.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ namespace storage_internal {
2727
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
2828
namespace {
2929

30-
std::size_t MinLwmValue() { return 256 * 1024; }
30+
std::size_t MinLwmValue() { return 16 * 1024 * 1024; }
3131

3232
std::size_t MaxLwmValue() {
3333
if (std::numeric_limits<std::size_t>::digits < 64) {

google/cloud/storage/tests/async_client_integration_test.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -451,9 +451,9 @@ TEST_F(AsyncClientIntegrationTest, StartBufferedUploadEmpty) {
451451
TEST_F(AsyncClientIntegrationTest, StartBufferedUploadMultiple) {
452452
auto client = AsyncClient(TestOptions());
453453
auto object_name = MakeRandomObjectName();
454-
// Create a small block to send over and over.
455-
auto constexpr kBlockSize = 256 * 1024;
456-
auto constexpr kBlockCount = 16;
454+
// Create a block to send over and over.
455+
auto constexpr kBlockSize = 16 * 1024 * 1024;
456+
auto constexpr kBlockCount = 3;
457457
auto const block = MakeRandomData(kBlockSize);
458458

459459
auto w =

0 commit comments

Comments
 (0)