Skip to content

Commit 9c535b2

Browse files
authored
chore: remove installation of system deps in nox (googleapis#17265)
Remove installing dependencies for system tests from `core_deps_from_source` and `prerelease_deps` nox sessions which only run unit tests.
1 parent d4d8855 commit 9c535b2

9 files changed

Lines changed: 0 additions & 144 deletions

File tree

packages/gapic-generator/gapic/templates/noxfile.py.j2

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -472,14 +472,6 @@ def prerelease_deps(session, protobuf_implementation):
472472
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
473473
session.install(*unit_deps_all)
474474

475-
# Install dependencies for the system test environment
476-
system_deps_all = (
477-
SYSTEM_TEST_STANDARD_DEPENDENCIES
478-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
479-
+ SYSTEM_TEST_EXTRAS
480-
)
481-
session.install(*system_deps_all)
482-
483475
# Because we test minimum dependency versions on the minimum Python
484476
# version, the first version we test with in the unit tests sessions has a
485477
# constraints file containing all dependencies and extras.
@@ -592,14 +584,6 @@ def core_deps_from_source(session, protobuf_implementation):
592584
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
593585
session.install(*unit_deps_all)
594586

595-
# Install dependencies for the system test environment
596-
system_deps_all = (
597-
SYSTEM_TEST_STANDARD_DEPENDENCIES
598-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
599-
+ SYSTEM_TEST_EXTRAS
600-
)
601-
session.install(*system_deps_all)
602-
603587
# Because we test minimum dependency versions on the minimum Python
604588
# version, the first version we test with in the unit tests sessions has a
605589
# constraints file containing all dependencies and extras.

packages/gapic-generator/tests/integration/goldens/asset/noxfile.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -464,14 +464,6 @@ def prerelease_deps(session, protobuf_implementation):
464464
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
465465
session.install(*unit_deps_all)
466466

467-
# Install dependencies for the system test environment
468-
system_deps_all = (
469-
SYSTEM_TEST_STANDARD_DEPENDENCIES
470-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
471-
+ SYSTEM_TEST_EXTRAS
472-
)
473-
session.install(*system_deps_all)
474-
475467
# Because we test minimum dependency versions on the minimum Python
476468
# version, the first version we test with in the unit tests sessions has a
477469
# constraints file containing all dependencies and extras.
@@ -584,14 +576,6 @@ def core_deps_from_source(session, protobuf_implementation):
584576
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
585577
session.install(*unit_deps_all)
586578

587-
# Install dependencies for the system test environment
588-
system_deps_all = (
589-
SYSTEM_TEST_STANDARD_DEPENDENCIES
590-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
591-
+ SYSTEM_TEST_EXTRAS
592-
)
593-
session.install(*system_deps_all)
594-
595579
# Because we test minimum dependency versions on the minimum Python
596580
# version, the first version we test with in the unit tests sessions has a
597581
# constraints file containing all dependencies and extras.

packages/gapic-generator/tests/integration/goldens/credentials/noxfile.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -464,14 +464,6 @@ def prerelease_deps(session, protobuf_implementation):
464464
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
465465
session.install(*unit_deps_all)
466466

467-
# Install dependencies for the system test environment
468-
system_deps_all = (
469-
SYSTEM_TEST_STANDARD_DEPENDENCIES
470-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
471-
+ SYSTEM_TEST_EXTRAS
472-
)
473-
session.install(*system_deps_all)
474-
475467
# Because we test minimum dependency versions on the minimum Python
476468
# version, the first version we test with in the unit tests sessions has a
477469
# constraints file containing all dependencies and extras.
@@ -584,14 +576,6 @@ def core_deps_from_source(session, protobuf_implementation):
584576
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
585577
session.install(*unit_deps_all)
586578

587-
# Install dependencies for the system test environment
588-
system_deps_all = (
589-
SYSTEM_TEST_STANDARD_DEPENDENCIES
590-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
591-
+ SYSTEM_TEST_EXTRAS
592-
)
593-
session.install(*system_deps_all)
594-
595579
# Because we test minimum dependency versions on the minimum Python
596580
# version, the first version we test with in the unit tests sessions has a
597581
# constraints file containing all dependencies and extras.

packages/gapic-generator/tests/integration/goldens/eventarc/noxfile.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -464,14 +464,6 @@ def prerelease_deps(session, protobuf_implementation):
464464
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
465465
session.install(*unit_deps_all)
466466

467-
# Install dependencies for the system test environment
468-
system_deps_all = (
469-
SYSTEM_TEST_STANDARD_DEPENDENCIES
470-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
471-
+ SYSTEM_TEST_EXTRAS
472-
)
473-
session.install(*system_deps_all)
474-
475467
# Because we test minimum dependency versions on the minimum Python
476468
# version, the first version we test with in the unit tests sessions has a
477469
# constraints file containing all dependencies and extras.
@@ -584,14 +576,6 @@ def core_deps_from_source(session, protobuf_implementation):
584576
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
585577
session.install(*unit_deps_all)
586578

587-
# Install dependencies for the system test environment
588-
system_deps_all = (
589-
SYSTEM_TEST_STANDARD_DEPENDENCIES
590-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
591-
+ SYSTEM_TEST_EXTRAS
592-
)
593-
session.install(*system_deps_all)
594-
595579
# Because we test minimum dependency versions on the minimum Python
596580
# version, the first version we test with in the unit tests sessions has a
597581
# constraints file containing all dependencies and extras.

packages/gapic-generator/tests/integration/goldens/logging/noxfile.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -464,14 +464,6 @@ def prerelease_deps(session, protobuf_implementation):
464464
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
465465
session.install(*unit_deps_all)
466466

467-
# Install dependencies for the system test environment
468-
system_deps_all = (
469-
SYSTEM_TEST_STANDARD_DEPENDENCIES
470-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
471-
+ SYSTEM_TEST_EXTRAS
472-
)
473-
session.install(*system_deps_all)
474-
475467
# Because we test minimum dependency versions on the minimum Python
476468
# version, the first version we test with in the unit tests sessions has a
477469
# constraints file containing all dependencies and extras.
@@ -584,14 +576,6 @@ def core_deps_from_source(session, protobuf_implementation):
584576
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
585577
session.install(*unit_deps_all)
586578

587-
# Install dependencies for the system test environment
588-
system_deps_all = (
589-
SYSTEM_TEST_STANDARD_DEPENDENCIES
590-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
591-
+ SYSTEM_TEST_EXTRAS
592-
)
593-
session.install(*system_deps_all)
594-
595579
# Because we test minimum dependency versions on the minimum Python
596580
# version, the first version we test with in the unit tests sessions has a
597581
# constraints file containing all dependencies and extras.

packages/gapic-generator/tests/integration/goldens/logging_internal/noxfile.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -464,14 +464,6 @@ def prerelease_deps(session, protobuf_implementation):
464464
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
465465
session.install(*unit_deps_all)
466466

467-
# Install dependencies for the system test environment
468-
system_deps_all = (
469-
SYSTEM_TEST_STANDARD_DEPENDENCIES
470-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
471-
+ SYSTEM_TEST_EXTRAS
472-
)
473-
session.install(*system_deps_all)
474-
475467
# Because we test minimum dependency versions on the minimum Python
476468
# version, the first version we test with in the unit tests sessions has a
477469
# constraints file containing all dependencies and extras.
@@ -584,14 +576,6 @@ def core_deps_from_source(session, protobuf_implementation):
584576
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
585577
session.install(*unit_deps_all)
586578

587-
# Install dependencies for the system test environment
588-
system_deps_all = (
589-
SYSTEM_TEST_STANDARD_DEPENDENCIES
590-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
591-
+ SYSTEM_TEST_EXTRAS
592-
)
593-
session.install(*system_deps_all)
594-
595579
# Because we test minimum dependency versions on the minimum Python
596580
# version, the first version we test with in the unit tests sessions has a
597581
# constraints file containing all dependencies and extras.

packages/gapic-generator/tests/integration/goldens/redis/noxfile.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -464,14 +464,6 @@ def prerelease_deps(session, protobuf_implementation):
464464
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
465465
session.install(*unit_deps_all)
466466

467-
# Install dependencies for the system test environment
468-
system_deps_all = (
469-
SYSTEM_TEST_STANDARD_DEPENDENCIES
470-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
471-
+ SYSTEM_TEST_EXTRAS
472-
)
473-
session.install(*system_deps_all)
474-
475467
# Because we test minimum dependency versions on the minimum Python
476468
# version, the first version we test with in the unit tests sessions has a
477469
# constraints file containing all dependencies and extras.
@@ -584,14 +576,6 @@ def core_deps_from_source(session, protobuf_implementation):
584576
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
585577
session.install(*unit_deps_all)
586578

587-
# Install dependencies for the system test environment
588-
system_deps_all = (
589-
SYSTEM_TEST_STANDARD_DEPENDENCIES
590-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
591-
+ SYSTEM_TEST_EXTRAS
592-
)
593-
session.install(*system_deps_all)
594-
595579
# Because we test minimum dependency versions on the minimum Python
596580
# version, the first version we test with in the unit tests sessions has a
597581
# constraints file containing all dependencies and extras.

packages/gapic-generator/tests/integration/goldens/redis_selective/noxfile.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -464,14 +464,6 @@ def prerelease_deps(session, protobuf_implementation):
464464
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
465465
session.install(*unit_deps_all)
466466

467-
# Install dependencies for the system test environment
468-
system_deps_all = (
469-
SYSTEM_TEST_STANDARD_DEPENDENCIES
470-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
471-
+ SYSTEM_TEST_EXTRAS
472-
)
473-
session.install(*system_deps_all)
474-
475467
# Because we test minimum dependency versions on the minimum Python
476468
# version, the first version we test with in the unit tests sessions has a
477469
# constraints file containing all dependencies and extras.
@@ -584,14 +576,6 @@ def core_deps_from_source(session, protobuf_implementation):
584576
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
585577
session.install(*unit_deps_all)
586578

587-
# Install dependencies for the system test environment
588-
system_deps_all = (
589-
SYSTEM_TEST_STANDARD_DEPENDENCIES
590-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
591-
+ SYSTEM_TEST_EXTRAS
592-
)
593-
session.install(*system_deps_all)
594-
595579
# Because we test minimum dependency versions on the minimum Python
596580
# version, the first version we test with in the unit tests sessions has a
597581
# constraints file containing all dependencies and extras.

packages/gapic-generator/tests/integration/goldens/storagebatchoperations/noxfile.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -464,14 +464,6 @@ def prerelease_deps(session, protobuf_implementation):
464464
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
465465
session.install(*unit_deps_all)
466466

467-
# Install dependencies for the system test environment
468-
system_deps_all = (
469-
SYSTEM_TEST_STANDARD_DEPENDENCIES
470-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
471-
+ SYSTEM_TEST_EXTRAS
472-
)
473-
session.install(*system_deps_all)
474-
475467
# Because we test minimum dependency versions on the minimum Python
476468
# version, the first version we test with in the unit tests sessions has a
477469
# constraints file containing all dependencies and extras.
@@ -584,14 +576,6 @@ def core_deps_from_source(session, protobuf_implementation):
584576
unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES
585577
session.install(*unit_deps_all)
586578

587-
# Install dependencies for the system test environment
588-
system_deps_all = (
589-
SYSTEM_TEST_STANDARD_DEPENDENCIES
590-
+ SYSTEM_TEST_EXTERNAL_DEPENDENCIES
591-
+ SYSTEM_TEST_EXTRAS
592-
)
593-
session.install(*system_deps_all)
594-
595579
# Because we test minimum dependency versions on the minimum Python
596580
# version, the first version we test with in the unit tests sessions has a
597581
# constraints file containing all dependencies and extras.

0 commit comments

Comments
 (0)