The itemIconStyle property was declared in the wrong way.#156
Open
dnlsilva wants to merge 7 commits intorenrizzolo:masterfrom
Open
The itemIconStyle property was declared in the wrong way.#156dnlsilva wants to merge 7 commits intorenrizzolo:masterfrom
dnlsilva wants to merge 7 commits intorenrizzolo:masterfrom
Conversation
Owner
|
Good catch, thanks. |
Author
|
Done. |
|
This PR is stale because it has been open 45 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you check the ItemIcon.js file, you can see that in its properties there is one declared with the name itemIconStyle, but in the RowItem.js file the style property is declared, which makes the property declaration not working.
With this change by declaring:
Ex:
styles={{ itemIconStyle: {width: 50, height: 50} }}It is possible to see the changes.
TD;LR:
itemIconStyledoes not work as expected.